Except still to be ported patches in the current queue, meaning:

Not contained in this sync, because to be ported separately:

#830228: Weights of submit buttons of webforms are not modified
#785460: Users have a hard time understand how exactly the Mollom mode is set

Also not contained, because still unfinished and to be ported over there:

#789812: Add ability to block profane content

Contained in this global sync, could also be re-opened:

#712570: Send more data for checkCaptcha

CommentFileSizeAuthor
#17 mollom-DRUPAL-6--1.sync_.17.patch29.88 KBsun
#13 mollom-DRUPAL-6--1.sync_.13.patch29.45 KBsun
#11 mollom-DRUPAL-6--1.sync_.6.patch29.74 KBsun
#10 mollom-DRUPAL-6--1.sync_.6-D6.patch29.74 KBsun
#7 mollom-DRUPAL-6--1.sync_.6-D6.patch29.74 KBsun
#5 mollom-HEAD.sync_.5.patch11.48 KBsun
#4 mollom-HEAD.sync_.3.patch11.54 KBsun
#2 mollom-HEAD.sync_.2.patch10.87 KBsun
mollom-DRUPAL-6--1.sync_.0.patch29.39 KBsun
mollom-HEAD.sync_.0.patch11.37 KBsun

Comments

Status: Needs review » Needs work

The last submitted patch, mollom-DRUPAL-6--1.sync_.0.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review
StatusFileSize
new mollom-HEAD.sync_.2.patch10.87 KB

Focusing on D7 first because of #866306: Failing tests

Status: Needs review » Needs work

The last submitted patch, mollom-HEAD.sync_.2.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review
StatusFileSize
new mollom-HEAD.sync_.3.patch11.54 KB

Of course. To revert assertMollomWatchdogMessages(), we also need to apply the corresponding installation/status handling change.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
StatusFileSize
new mollom-HEAD.sync_.5.patch11.48 KB

Forgot to remove something.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
StatusFileSize
new mollom-DRUPAL-6--1.sync_.6-D6.patch29.74 KB

#5 is RTBC, not this one. Just attaching counter-sync patch for D6 to proceed with later on.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed #5 to CVS HEAD.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Fixed » Needs review
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
StatusFileSize
new mollom-DRUPAL-6--1.sync_.6-D6.patch29.74 KB

Odd. I thought it would start to test patches with "-D6" suffix when switching to 6.x.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
StatusFileSize
new mollom-DRUPAL-6--1.sync_.6.patch29.74 KB

err. *headdesks*

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

#11: mollom-DRUPAL-6--1.sync_.6.patch queued for re-testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
StatusFileSize
new mollom-DRUPAL-6--1.sync_.13.patch29.45 KB 
+++ mollom.admin.inc	3 Aug 2010 11:22:40 -0000
@@ -319,9 +320,6 @@ function mollom_admin_blacklist_form(&$f
-  $form['entry']['actions'] = array(
-    '#tree' => FALSE,
-  );

This shouldn't have passed. So I can only guess that those 0 (zero) passes reported by PIFR actually means that no tests were executed. (see #873496: Bogus test results PASSED: [[SimpleTest]]: [MySQL] 0 passes.)

Powered by Dreditor.

Status: Needs review » Needs work

The last submitted patch, mollom-DRUPAL-6--1.sync_.13.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review

#13: mollom-DRUPAL-6--1.sync_.13.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, mollom-DRUPAL-6--1.sync_.13.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new mollom-DRUPAL-6--1.sync_.17.patch29.88 KB

Found the problem.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit eb40f94 on master, fai6, 8.x-2.x, fbajs, actions by Dries: 
    - Patch #872646 by sun: sync.

  • Commit eb40f94 on master, fai6, 8.x-2.x, fbajs, actions by Dries: 
    - Patch #872646 by sun: sync.