I have a gallery set up now with Gallerific. I noticed that if I click the same picture more than once in quick succession (totally possible in todays fast paced clicking world) the image is loaded multiple times underneath.

It's kinda hard to explain so I've attached an image showing what is happening. Is there a fix for this? This is the last big element of a site I'm developing that will launch soon- I'll have to find a new gallery if I can't find a remedy.

Comments

macandrow’s picture

Ok, this issue still persists. Has no one else run into this?

acouch’s picture

Do you have other modules that use jquery or javascript on your site? If so can you remove them and see if this behavior still persists? What browser / OS are you using? Does this happen on all browsers for you? Awesome photo btw!

manfer’s picture

I think this is something that happens in galleriffic itself. You can make it happen on gallerific minimal implementation example.

On the rest of galleriffic examples that is not happening.

I don't know the inner working of that library but it seems the examples that don't have that issue are using one library init parameter, syncTransitions: true, which by default has a false value. I mean,

var gallery = $('#thumbs').galleriffic({ 
   delay: x,
   .
   .
   .
   syncTransitions: true,
   .
   .
   .
});
acouch’s picture

hi Manfer:

thanks for finding that. @macandrow, if you change 'syncTransitions: true,' to the module file (around line 35) does it fix that behavior?

manfer’s picture

Status: Active » Needs review
StatusFileSize
new5.82 KB

Patch againts 6.x-1.x-dev that adds a sync transitions option to the galleriffic style after autostart option, so it can be configured as true or false.

acouch’s picture

Thanks. Patch looks good. Will commit when I get a chance.

macandrow’s picture

@aaroncouch behavior is fixed, I'll patch everything up just to be safe.

mrgoltra’s picture

Hello,

Wondering if the patch has been committed current release or dev?

Thank you,

Mark

acouch’s picture

Not yet. Promise to in the next couple of days.

adasgt’s picture

Hi acouch,

The issue still persists in version 6.x.1.1.

Any idea when the fix will be available.

Changing the "syncTransitions" to true in "jquery.gallerific.js" file partially fixes the problem. Though it does not load multiple images, but during transition to next image, previous image is still visible for few seconds.

Thanks

adasgt’s picture

Issue resolved: Edit jquery.galleriffic.js file and add following lines:

1.
Add the following line after line # 627 i.e. var nextIndex = this.getNextIndex(imageData.index);

this.$imageContainer.empty();

2.
Add the following line after line # 641 i.e. var newCaption = 0;

this.$captionContainer.empty();

Check the issue @ http://code.google.com/p/galleriffic/issues/detail?id=95&q=multiple%20image

acouch’s picture

Thanks adasgt

I will commit this as soon as I am able.

thedavidmeister’s picture

Priority: Normal » Major

please commit this!

double clicking a thumbnail causes the number of slides visible to increase.

many casual users double click just about everything, so this totally breaks the gallery.

thedavidmeister’s picture

incidently #11 fixed this for me :) thanks!

acouch’s picture

Status: Needs review » Postponed (maintainer needs more info)

I have updated the way that the js loads.

I didn't commit get a chance to commit the fixes above as I think the changes I made should stop this from happening.

Can folks who had this problem please update and test?

If it is still an issue I will promptly commit those changes in the js file.

Thanks!

joeytheman’s picture

I was experiencing the same issue and #11 worked for me also.

acouch’s picture

Status: Postponed (maintainer needs more info) » Closed (fixed)

Seems like this is fixed.

dlufkin’s picture

Status: Closed (fixed) » Needs work

This is still an issue. The fixes in #11 work, but they need to be committed to the js.

Patch applied, functioning properly: http://swellfineart.com/gallery-hubley-waves

Patch not applied, not functioning properly: http://swell.goodpagescom/gallery-hubley-waves

acouch’s picture

Have you upgraded to the latest version?

acouch’s picture

Status: Needs work » Closed (cannot reproduce)

Closing this unless someone else is still having issues. Please download the latest version before re-opening.

ressa’s picture

Version: 6.x-1.1 » 7.x-1.1
Status: Closed (cannot reproduce) » Active

Still an issue in version 7.x-1.1, adding the two lines mentioned in post #11 fixes it, thanks @adasgt.

acouch’s picture

Status: Active » Needs work

If this is working for you can you please submit a patch against the latest dev version?

ressa’s picture

Version: 7.x-1.1 » 7.x-1.x-dev
Component: Miscellaneous » Code
Status: Needs work » Needs review
StatusFileSize
new618 bytes

Here is the patch for Views Galleriffic.
I hope I haven't messed up too badly, it's my first git patch :-)

acouch’s picture

If someone can find the time to RTBC this I will gladly commit. Sorry I don't have time myself right now. But if it is RTBCed I will commit immediately.

Spieler’s picture

#11 (comment) Worked for me.

Thanks

m.stenta’s picture

Status: Needs review » Reviewed & tested by the community

#23 works. RTBC!

Also, closing #1908052: Duplicate Images on double-click as a duplicate.