'autocreate' == 0

A year later, I am experiencing a similar issue, resolved by this patch. I am programmatically creating nodes with term reference fields, and if I have no terms, then a term with tid = 0 ends up in taxonomy_field_presave(), and, as you say, errors abound.

I have applied your patch and all is well again. Can this be included in a future release? A stricter comparison can't hurt in this context, can it?

Aha! I think I've encountered this before as well.

Well obviously it needs a reroll, but yeah.

Tagging as novice to reroll.

Rerolled.

Rolled of master, not 8.x. Trying again :)

Git environment is screwy. Trying again :/

That looks good. Thanks @aaron.r.carlton!

#11: term_reroll-873722-11.patch queued for re-testing.

Re-rolled patch and tested. Should apply cleanly now.

Thanks @damiankloip; that looks good.

I wonder if we can create a test with the functional bug described in #4?

Hi xjm, I don't have a proper test environment set up yet, but here's the code that triggers the bug.

function autocreatebug_run() {
  $node = new stdClass();
  $node->type = "article";
  node_object_prepare($node);
  $node->uid = 1;
  $node->language = LANGUAGE_NONE;

  $node->title = "This will trigger the bug!";
  $node->field_tags[$node->language][0]["tid"] = 0;

  node_submit($node);
  node_save($node);
}

Before applying the patch, I get these errors:

$ drush ev 'autocreatebug_run()'
array_flip(): Can only flip STRING and INTEGER values!                     [warning]
entity.controller.inc:182
WD node: EntityMalformedException: Missing bundle property on entity of    [error]
type taxonomy_term. in entity_extract_ids() (line 148 of
/home/evanh/.web/autocreate/modules/entity/entity.module).
WD php: EntityMalformedException: Missing bundle property on entity of type[error]
taxonomy_term. in entity_extract_ids() (line 148 of
/home/evanh/.web/autocreate/modules/entity/entity.module).
EntityMalformedException: Missing bundle property on entity of type taxonomy_term. in entity_extract_ids() (line 148 of /home/evanh/.web/autocreate/modules/entity/entity.module).
Drush command terminated abnormally due to an unrecoverable error.         [error]

After applying the patch, there are no errors. An row appears in {taxonomy_index} relating the new node to tid 0, but there is no row for tid 0 in {taxonomy_term_data} and the UI shows no terms for the new node. An edit -> save cycle on the UI will remove the row in {taxonomy_index}. I am open to suggestion if my test code breaks an API expectation.

The 8.x branch has drifted somewhat since the patch in #16; attached is a re-roll that applies cleanly today.

If you (or anyone) can point me to the proper test-bench setup instructions, I will create a proper test.

Darn that testbot. I can't figure out why the old patch didn't apply. Now I've followed the instructions from http://drupal.org/node/707484 and used git diff instead of git format-patch ...

Sorry, it's all me. I was using a months-old version of the 8.x branch. My bad. Please hold while I get back up to speed -- the patch in #16 no longer applies and my PHP version is too old to test anything. This patch is, thus, untested.

I'm back, with the real latest 8.x. I have a silly-short module with this code:

function autocreatebug_run() {
  $node = new stdClass();
  $node->type = "article";
  node_object_prepare($node);
  $node->uid = 1;
  $node->language = 'und';

  $node->title = "This will trigger the bug!";
  $node->field_tags[$node->language][0]["tid"] = 0;

  node_submit($node);
  node_save($node);
}

In 8.x I can trigger the bug like this:

$ drush ev 'autocreatebug_run()'
array_flip(): Can only flip STRING and INTEGER values! entity.controller.inc:186                        [warning]
WD taxonomy_term: EntityMalformedException: Missing bundle property on entity of type taxonomy_term. in [error]
entity_extract_ids() (line 149 of /home/evanh/.web/autocreate/core/modules/entity/entity.module).
WD node: EntityStorageException: Missing bundle property on entity of type taxonomy_term. in            [error]
EntityDatabaseStorageController->save() (line 541 of
/home/evanh/.web/autocreate/core/modules/entity/entity.controller.inc).
WD php: EntityStorageException: Missing bundle property on entity of type taxonomy_term. in             [error]
EntityDatabaseStorageController->save() (line 541 of
/home/evanh/.web/autocreate/core/modules/entity/entity.controller.inc).
EntityStorageException: Missing bundle property on entity of type taxonomy_term. in EntityDatabaseStorageController->save() (line 541 of /home/evanh/.web/autocreate/core/modules/entity/entity.controller.inc).
Drush command terminated abnormally due to an unrecoverable error.  

And the attached patch allows the above command to run without errors.

I don't have the automated test environment set up yet, so I don't have a patch for the test yet.

#22: autocreate.patch queued for re-testing.

Reroll. I'll see if I can cook up a test for this soon.

Sending to the bot.

Removing reroll tag.

#26: autocreate-term-873722-26.patch queued for re-testing.

Is this issue even still relevant now? I think a lot of this code has changed. On top of that we have the TypedData api.

Well after #1847596: Remove Taxonomy term reference field in favor of Entity reference the auto create api is yet again changed as it's using ER field now. They handle autocreate complete differently. See \Drupal\Core\Entity\Element\EntityAutocomplete::validateEntityAutocomplete() for details.
But this is still an issue in D7 so moving back to D7 issue queue.

Tagging Novice for the reroll (of #16) and tests

Let's try and re-roll this.

Re-rolled patch from #16. [Patch tested on git and simplytest.me]
Please review :)

Could have failed because I edited the comment during the last phases of the test...

As expected, the second test passed.

Patch works, but apparently, fails on PHP 5.3 tests. Could be an issue with the test bot.

Ugh, stop it testbot.

Yay, test passed. I'm unassigning so that someone can review and commit this.

Review please?

The patch #35 looks good. Adding a simple test to show the failure with tid = 0.

Thanks for adding the test.

Looks good to me!

Thanks all who contributed! Commited and pushed to 7.x.