Hi,

Currently, this project won't install with Drush Make, because the Quail library has to be extracted directly into the module directory, and not in a sub-directory.
The alternatives are :
- integrating with Libraries API;
- simply moving the library into sites/all/libraries;
- simply moving the library into a sub-directory of the module.

Would it be possible to do one of those ?

Best regards,

CommentFileSizeAuthor
#2 874068.patch2.81 KBsimon georges

Comments

David Stosik’s picture

David Stosik commented

By the way, uncompressing the library directly inside the module folder is not very elegant : mixing the module code with the library code, without any clear separation, doesn't seem good.
From my point of view, the best approach would be to follow the trend, and put the library inside sites/all/libraries/quail.

Regards,
David

simon georges’s picture

simon georges commented
Status: Active » Needs review
StatusFileSize
new 874068.patch2.81 KB

Here is a patch looking for the Quail library into the sites/all/libraries directory.

It works for me (and accessible_content is now installable using Drush Make), so don't hesitate to test it and provide feedback.

Regards,

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Reviewed & tested by the community

Applied the patch, but I suggest the sub-directory 'quail' be put into sites/all/libraries (so the mail file is available at sites/all/libraries/quail/quail.php), as opposed to the full quail directory itself, which has executable PHP code for things like SimpleTesting that should probably not be in a public directory.

Aside from that, tests seem to pass so I'm going to rewrite a few strings in reporting and commit to dev this evening.

Anonymous’s picture

Anonymous (not verified) commented

Added this in dev under commit 403108. Will try to roll into a new version soon.

David Stosik’s picture

David Stosik commented

kevee, your suggestion keeping only the quail directory throws two issues :
- the LICENSE.txt and README.txt are lost
- I don't think Drush can handle only extracting a subpath of an archive.

Regards,
David

simon georges’s picture

simon georges commented

I fully agree with David: if you only keep the quail directory, apart from the licensing issue, it prevents the installation using Drush Make, which is the whole point of the issue ;)

Regards,
Simon

Anonymous’s picture

Anonymous (not verified) commented

OK, then perhaps the best thing to do at this point is to have the full library installed and then in the install instructions let people know that the test and example files that come with the library are there also, and if they don't want them to be publicly available to put a .htaccess file in there.

For future releases of the library, I will add these instructions as well. I put in an issue at http://code.google.com/p/quail-lib/issues/detail?id=25. I'm on a phone right now, but I'll commit those changes to directories soon.

Anonymous’s picture

Anonymous (not verified) commented

Another possible issue is that by default QUAIL is archived in a directory with a version number appended (like "quail-lib-0.3.8") - not being a big drush user myself, I was wondering if I could get feedback on that. I know you can do something like:

libraries[quail][directory_name] = 'quail'

Would that suffice? If not, I'm going to have to change how QUAIL gets packaged, which was initially with version numbers appended to avoid confusion because the development cycle was very fast, but it's less so now.

simon georges’s picture

simon georges commented

@kevee, you're exactly right: when using Drush Make, if you add the line you mentionned, the file is extracted into a quail directory. The lines I used to test are :

libraries[quail][download][type] = get
libraries[quail][download][url] = http://quail-lib.googlecode.com/files/quail-lib-0.3.8.tar.gz
libraries[quail][directory_name] = quail

Regards,

Anonymous’s picture

Anonymous (not verified) commented
Status: Reviewed & tested by the community » Fixed

Just committed this to dev. This change, along with the upgrade to handle either the BeautyTips 1.0 or 2.0 module will be rolled into a 1.1 release soon.

simon georges’s picture

simon georges commented

Thanks a lot !

Regards,
Simon

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.