A todo.

CommentFileSizeAuthor
#5 role_weights_to_drupal5_r4.patch5.03 KBnedjo
#3 role_weights_to_drupal5_r3.patch3.94 KBpfaocle
#2 role_weights_to_drupal5_r2.patch1.85 KBpfaocle
#1 role_weights_to_drupal5_noforms.patch2.96 KBpfaocle

Comments

pfaocle’s picture

pfaocle
He/Him
Primary language English
commented
Assigned: Unassigned » pfaocle
Status: Active » Needs work
StatusFileSize
new role_weights_to_drupal5_noforms.patch2.96 KB

Patch with simple changes. I've not had time to look through or test any of the forms/form_alter stuff yet.

pfaocle’s picture

pfaocle
He/Him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new role_weights_to_drupal5_r2.patch1.85 KB

OK, the uninstall hook is in, so here's a simplified patch for a 5.0 update.

This patch has 2-3 notes for me to test/look at tomorrow. Untested.

pfaocle’s picture

pfaocle
He/Him
Primary language English
commented
Status: Needs review » Needs work
StatusFileSize
new role_weights_to_drupal5_r3.patch3.94 KB

A bit more. Still a bit wonky - the main issue is that we're now locked out of editing the two default roles in user.module, lines 1888-1893:

  function user_admin_role() {
    $id = arg(4);
    if ($id) {
      if (DRUPAL_ANONYMOUS_RID == $id || DRUPAL_AUTHENTICATED_RID == $id) {
        drupal_goto('admin/user/roles');
      }

So just retheming user_admin_new_role() to include the edit links isn't going to cut it.

pfaocle’s picture

pfaocle
He/Him
Primary language English
commented

Just for reference - issue/patch for the locked roles editing.

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
StatusFileSize
new role_weights_to_drupal5_r4.patch5.03 KB

Yes, it's too bad that patch went in without us noticing!

Here's an updated patch with a fix. We avoid the drupal_goto() by shifting the rid values down by two. Then we shift them back up to get them right again. It's tricky, but I guess it works.

pfaocle’s picture

pfaocle
He/Him
Primary language English
commented
Status: Needs work » Needs review

Yes, it's too bad that patch went in without us noticing!

Er, yeah. Ahem ;)

Will be able to take a look at this patch tomorrow - cheers nedjo!

pfaocle’s picture

pfaocle
He/Him
Primary language English
commented
Status: Needs review » Fixed

Committed this to HEAD. Testing appreciated now - will tag for DRUPAL-5 soon.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)