Needs work
Project:
Location
Version:
7.x-3.x-dev
Component:
Data update
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
4 Aug 2010 at 22:33 UTC
Updated:
6 Sep 2015 at 08:32 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
gregglesBummer. A lot of these had lat/lon of zero when they actually should have contained data.
Attached is an updated file that is much better.
Comment #2
jackbravo commentedHi greggles. Your table is missing a few zipcodes =P. I do like the Viva México statement =).
Here is a table with more zipcodes. Data taken from http://www.geonames.org/
Hmmmmm. tried uploading the file but it is too big. Gzipped is 3MB. How can I add it to this issue?
Comment #3
gregglesI realized after the fact it's missing things. I just based it on Wikipedia, but that's obviously not complete.
Maybe you could break it apart into multiple files?
Comment #4
gregglesA better status.
Comment #5
jackbravo commentedOk. I think I was using the wrong file. Gzipped it does fit. Unzipped it is 3 MB just like the US zipcodes file. And it does fit, maybe my connection was wrong and that's why it failed. Anyway.
here it is.
Comment #6
gregglesI think it should be one insert per row instead of multi-insert.
Also, it's missing the Viva México :)
Comment #7
jackbravo commentedThe multivalue insert allowed me to reduce the size of the file from 4MB to 3. And it is also how I see the current zipcodes.xx.mysql files are structured. Any specific reason why it should be one insert per row?
As for the Viva México, you are right!!! Totally forgot =)
added.
Comment #8
jackbravo commentedUps! Now really added =P.
Comment #9
gregglesOK. I'm not sure if the multi-insert is as compatible across databases but I agree the file size savings is worth something.
Comment #10
jackbravo commentedThat's a good question. I looked into postgres, and seems like it is compatible http://www.postgresql.org/docs/8.2/interactive/sql-insert.html.
On the other hand, on sqlite it is not supported. http://www.sqlite.org/lang_insert.html =(.
Comment #11
podarokpostponed before tests fix
#1931088: [META] Fixing tests
Comment #12
podaroktests fixed #1931088: [META] Fixing tests
lets go
Please. do provide a patch against latest dev for review
Comment #13
podaroklatest version tag
Comment #13.0
podarokUpdated issue summary.
Comment #14
Yurii Krysiuk commentedComment #15
Yurii Krysiuk commentedCreated patch file with zip codes for Mexico
Comment #16
Yurii Krysiuk commentedComment #17
podarokthanks, commited
Comment #19
jackbravo commentedThe patch by Yuriy Krysiuk contains zipcodes for australia not mexico.
Comment #20
Maxis commented