hsudhof [hsudhof]

Thanks for your application. Quick note upfront:

one for the company account ("werk21" - seperate application later

Note that drupal.org user accounts are for individuals only. A CVS application for a user account of a group or company will be declined.

• The points reported in this review are not in order or importance / relevance.
• Most of the times I report the code that present an issue. In such cases, the same error can be present in other parts of the code; the fact I don't report the same issue more than once doesn't mean the same issue is not present in different places.
• Not all the reported points are application blockers; some of the points I report are simple suggestions to who applies for a CVS account. For a list of what is considered a blocker for the application approval, see CVS applications review, what to expect. Keep in mind the list is still under construction, and can be changed to adapt it to what has been found out during code review, or to make the list clearer to who applies for a CVS account.

1. See http://drupal.org/coding-standards to understand how a module should be written. In particular, see how the code should be formatted; how functions, constants, Drupal variables, and global variables defined from the module should be named.
   Check also you are not using tabs to indent the code.
2. There are parts of the code that have been commented out; that makes me think the code is not complete, contrary to what reported from the requirements.
3. Menu callback descriptions, and titles are not passed to t(), as that is already done from Drupal core code.
4. License files are not committed in Drupal.org repository.

5. 		l(t('Konfigurieren'), 'admin/build/portlets/edit/' . $id), 
   		l(t('Löschen'), 'admin/build/portlets/delete/' . $id),
   
   

   The literal string passed to t() needs to be in English.

6. 		$result = db_query('SELECT * from {portlets} where portlet_id = %d', $id);
   		$row = db_fetch_array($result);
   

   SQL reserved words needs to be written in uppercase characters.

7. 		'#description'	=> t('The block to use as portlet. This is independent from the block\'s settings. Note that blocks might be incompatible with AJAX loading.'),
   		'#options'		=> $options,
   

   Avoid to escape the string delimiter inside a literal string passed to t().

8. The code calls drupal_eval(), but it doesn't implement a permission that allows to use PHP code to users.

9. 								print t($portlet->subject);
   							} else {
   								print t($portlet->portlet_title);
   							}?></h2>
   

   The first argument of t() is a literal string.