Cannot export disabled flags to features

Patch didn't apply cleanly, but looks like the trouble lines were already fixed so removed them

This solves an issue where, when features computes whether it needs to act, fatal errored during export render, so +1!

Haven't tested the condition that this patch was originally created for though.

--relative :O

Tagging.

BTW, you can get a disabled flag with "flag_load($name, TRUE)". This function currently serves as a "menu loader" only, but I wish we'd switch to use it instead of flag_get_flag() because it's more consistent with the rest of Drupal's API (node_load(), user_load(), etc.)

One reason flags may be disabled is because their API version isn't compatible with the current API:

      // Disable flags that are not at the current API version.
      if (!isset($flag->api_version) || $flag->api_version < FLAG_API_VERSION) {
        $flag->status = FALSE;

(Snippet from flag.module.)

Exporting such flags may produce useless output. Shouldn't we exclude such flags from the exportables list?

Here's the patch with some minor modifications.

Overview:

(1) The 'disabled' attribute, in the context of Features, should be treated as any other attribute of the flag: be ignored. So we replace every flag_get_flag($name) call with flag_load($name, TRUE).

(2) But if a flag is disabled because it is incompatible, we print an error message and skip its export. (Why print a message? We don't have to but it's a helpful message: if one upgrades his Flag module he'll understand why his old default flags are ignored.)

(3) When we display the list of flags, we show absolutely all of them. This way, a "Recreate" of the module doesn't forget flags that are now disabled (or incompatible).

Committed.
http://drupal.org/cvs?commit=471078
http://drupal.org/cvs?commit=471080

(It might seem as if I'm pushing flag_load() through the back door, but there's no other (easy) way to get at a disabled flag; and flag_load() actually follows Drupal's naming conventions. (For uniformity's sake we might want to replace all flag_get_flag() calls with flag_load().))