CVS edit link for arritjenof

Hi,

I have been working with Drupal for a few years now, and i have developed several (custom) modules and themes for projects i have been working on.

Currently i've reached the point where i'm confident about my skills and expertise (but as ever still learning;), and i am creating modules in a generic (as opposed to custom) way, so that they can be 'plugged' into any drupal site, or multi-site setup.

I feel it'd just be a natural progression if i'd submit my work, and my knowledge and skills in general to the community.

Currently i have a specific module i'd like to submit to start with. It's a very simple one, but probably that's perfect to start-off with as a drupal module-contributor.

About the module;
It is an adapted version of the Facebook Share module: http://drupal.org/project/facebookshare called Hyves Share. Hyves is a sort of Facebook for dutch users.
A working version can be found here: http://www.moviezone.nl/label/content/shocking-blue
Note that this website is currently still in development. Also note that Drupal is installed in the /label subdirectory. The site running in the root there is actually another Drupal install.
I'm actually wondering if it'd be better to integrate the Hyves-functionality into the Facebook Share module itsself, but for now choose to make it a seperate module for a few reasons:
- simplicity: both modules are so super simple, it feels stupid to make things more complicated by intergrating them, since many Hyves-users probably don't need the Facebook-functionality and vise-versa.
- other, more generic socialnetwork-api-modules are in the making (or proposed) in the community. It makes more sense to intergrate the 'share this page' functionality on a more abstract-level in such a module, whenever they become available.
- time: i had to have this module ready in a few hours, no time to contact the developer, await an answer etc..

Apart from that, i'm also preparing a few other modules i have and make them ready for release into the community.
One particular module i'm exited about, and would like to share, is a module that (partly) integrates with Postfix (MTA). Currently it requires Postfix to be setup in such a way that it uses the module as a 'FILTER', to pipe incoming email for a specific (virtual) mailbox to. The module then processes the email, parses its' content, saves attachments (if available) and creates a new node with the contents of that email, together with a path-alias in 'short-url' format, and mails that short url back to the originating email-address.
This can effectively be used to quickly email photo's, video's or URL's from your mobile-phone to YOUR OWN site, and instantly get a reply with a shortened-URL to that content for use in for instance twitter.

Finally, i've just started a new job at a large, ducth public-broadcasting organisation (NCRV.nl) where i will be lead-php-/drupal-developer. Since they have made the complete transition (organisation-wide) a few years ago from a proprietary system to Drupal, and are supporting the opensource-philosophy, i'm planning to release as much of the work i'll be doing there into the community. Either as new modules, or as supporting effort, working on improving existing modules.

I hope this motivation is enough justification for a CVS-account ;)

[Edited by kiamlaluno to remove sensible data.]

CommentFileSizeAuthor
#1 hyvesshare.tgz9.2 KBarritjenof

Comments

arritjenof’s picture

arritjenof commented
StatusFileSize
new hyvesshare.tgz9.2 KB
arritjenof’s picture

arritjenof commented

hmm, bummer.

i shouldn't have included this personal info.
could someone please delete this?

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Postponed (maintainer needs more info) » Needs review

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review the code, pointing out what it needs to be changed.

arritjenof’s picture

arritjenof commented

thanks for removing the 'sensible' parts ;)

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work
  • The points reported in this review are not in order or importance / relevance.
  • Most of the times I report the code that present an issue. In such cases, the same error can be present in other parts of the code; the fact I don't report the same issue more than once doesn't mean the same issue is not present in different places.
  • Not all the reported points are application blockers; some of the points I report are simple suggestions to who applies for a CVS account. For a list of what is considered a blocker for the application approval, see CVS applications review, what to expect. Keep in mind the list is still under construction, and can be changed to adapt it to what has been found out during code review, or to make the list clearer to who applies for a CVS account. 
  1. version = "6.x-0.1"
project = "hyvesshare"

    Those lines must be removed.

  2. License files cannot be committed in Drupal.org repository. Projects committed in Drupal.org repository have the same license used by Drupal. 
  3. /**
 * Implements hook_install()
 */
function hyvesshare_install() {
}

    Hooks that are not required can be removed.
    Hook implementation comments should be like the following one:

    /**
 * Implements hook_menu().
 */

  4. function hyvesshare_uninstall() {
	variable_del('hyvesshare_types', '');
	variable_del('hyvesshare_location', '');
	variable_del('hyvesshare_text');
}

    variable_del() accepts only an argument.

  5. See http://drupal.org/coding-standards to understand how a module should be written. In particular, see how the code should be formatted.
    Verify you are using two spaces to indent the code, not tabs. 
  6. 	$('a.hyvesshare').click(function(e){
		window.open(this.href,'share on hyves','width=520,height=640');
		return false;
	});

    There is a function to translate strings used in JavaScript code.

  7. Remove the extraneous files.
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Closed (won't fix)

Please read the following links as this is very important information about CVS applications.

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for these applications. Please read Migrating from CVS Applications to (Git) Full Project Applications and Applying for permission to opt into security advisory coverage on how this affects and benefits you and the application process. In short, every user has now the permissions necessary to create new projects, but they need to apply for opt into security advisory coverage. Without applying, the projects will have a warning on projects that says:

This project is not covered by Drupal’s security advisory policy.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Component: Miscellaneous » new project application