I installed this module, but don't have the ACL button showing (as shown here: http://drupal.org/node/619178)

I have several webforms and none have this button, although this module is activated. Do I need to do something else to enable?

Stats:
Drupal 6.17
webform-DRUPAL-6--3 (6.x-3.x-dev)

CommentFileSizeAuthor
#18 webform_3_compatability-876064-18.patch2.04 KBimclean
#13 webform_3_compatability-876064-13.patch1.63 KBmonotaga
#8 754336-webform.patch1010 bytespvasener

Comments

bradfuller’s picture

bradfuller commented

Schema reported this:

webform_submissions_acl
o primary key: missing in database

So, this may be a clue. Here's the schema from the .install:

/**
* Implementation of hook_schema().
*
* Create the table for webform_submissions_acl entries.
*/
function webform_submissions_acl_schema() {
$schema['webform_submissions_acl'] = array(
'fields' => array(
'nid' => array(
'type' => 'int',
'not null' => TRUE,
'default' => 0
),
'uid' => array(selec
'type' => 'int',
'not null' => TRUE,
'default' => 0
),
),
'primary key' => array(),
'indexes' => array(
'uid' => array('nid'),
'uid' => array('uid')
),
);

return $schema;
}

quicksketch’s picture

quicksketch
he/him
commented
Title: No ACL button on Webform » Webform 3.x compatibility

Most likely this module is not compatible with Webform 3.x yet.

Hitmrrr’s picture

Hitmrrr commented

when module will compatible with Webform 3.x?

pbosmans’s picture

pbosmans commented

subscribing

Hitmrrr’s picture

Hitmrrr commented

subscribing

Hitmrrr’s picture

Hitmrrr commented

When this module will compatible with Webform 3.x?

daengo’s picture

daengo commented
Version: 6.x-1.x-dev » 6.x-1.0

Ditto. Is there a quick fix patch?

pvasener’s picture

pvasener commented
Status: Active » Needs review
StatusFileSize
new 754336-webform.patch1010 bytes

Here is a patch to make the tab show up in the new 'Webform' tab for webform 3.x

matt b’s picture

matt b
Primary language English
commented

Applied the patch. Can add a user via the Results Access tab. The user can review the Submissions summary table, but when clicking on 'View' gets an Access Denied message.

matt b’s picture

matt b
Primary language English
commented

Applied to dev version of this module and now it works fine. Good work - thanks! Reviewed and tested by me.

monotaga’s picture

monotaga commented

This patch also works for me in webform 3.x. Any chance we can get this patch applied to dev?

amysiano4x3’s picture

amysiano4x3 commented

Patch (on dev) worked for me as well in webform 3.x. Menu shows, though delete user was not "working.webform_submissions_acl.pages.inc" needs path updated as well. Not sure how to officially create a patch but here is what I updated.

foreach ($users as $user) {
- $rows[] = array(l($user->name, 'user/'. $user->uid), l(t('Delete'), 'node/'. $node->nid .'/edit/acl/delete/'. $user->uid));

+ $rows[] = array(l($user->name, 'user/'. $user->uid), l(t('Delete'), 'node/'. $node->nid .'/edit/webform/delete/'. $user->uid));

}

monotaga’s picture

monotaga commented
StatusFileSize
new webform_3_compatability-876064-13.patch1.63 KB

I've made a patch incorporating aksiano's issue above in #12.

investigacoes’s picture

investigacoes commented

applied the patch:

# git apply -v 754336-webform.patch
   Checking patch webform_submissions_acl.module...
   Applied patch webform_submissions_acl.module cleanly.

Results Access appeared, but links to blank page: node/xx/webform/acl

what's wrong?

monotaga’s picture

monotaga commented

investigacoes, are you using PHP 5.3? It might be issues with the references. I'm running into the same issue on my end. I'm removing the "&" from the values passed in functions to see if that fixes it. I'll upload a patch if I'm able to get it.

investigacoes’s picture

investigacoes commented

Hey monotaga,
Yes I'm using 5.3.2

Now I got an error:
warning: Parameter 1 to webform_submissions_acl_page() expected to be a reference, value given in /includes/menu.inc on line 349.
I read something about other module messing up with the values, but I have no idea how to fix this.

monotaga’s picture

monotaga commented

investigacoes, in short, you just need to remove the the "&" from the values passed in functions.

imclean’s picture

imclean commented
Version: 6.x-1.0 » 6.x-1.x-dev
StatusFileSize
new webform_3_compatability-876064-18.patch2.04 KB

Same as #13 but with the reference removed form webform_submissions_acl_page(). This works for me but I needed to clear the cache a couple of times. I'm not sure why the other callbacks aren't generating errors.

Zilvador’s picture

Zilvador commented

I am also very interested in seeing this bug being fixed as soon as possible.