The Popups API module has been deprecated, this module needs to be rewritten using ModalFrame.

CommentFileSizeAuthor
#4 modalframe.patch4.69 KBsirkitree
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

naadiya1’s picture

naadiya1 CreditAttribution: naadiya1 commented
Status: Active » Closed (duplicate)

Duplicate : http://drupal.org/node/876458

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Closed (duplicate) » Active

That ticket is for a different module.

sirkitree’s picture

sirkitree CreditAttribution: sirkitree commented
Version: 6.x-2.x-dev » 6.x-1.x-dev
Category: task » feature
Status: Active » Needs review

Hi Damien! I've done some work on this, please review here: http://github.com/sirkitree/flag_friend/commit/f3063af4fd185b530814d484a...

It only adds support, not a requirement and works pretty basically.

Also moving this to a feature request, because although popups is unsupported, I still support integration if a user chooses to use it.

I've also only written this for the 1.x version currently, but it should translate pretty well over to 2.x should crea wish port it.

sirkitree’s picture

sirkitree CreditAttribution: sirkitree commented
FileSize
modalframe.patch4.69 KB

Here it is as a proper patch for cvs.

thomjjames’s picture

thomjjames CreditAttribution: thomjjames commented

Popups API got a new maintainer a few months back and looks to be in active development: http://drupal.org/project/popups
Be great if the module support both popups and modal frames if it doesn't go although.

Cheers
Tom

sirkitree’s picture

sirkitree CreditAttribution: sirkitree commented
Status: Needs review » Closed (won't fix)

Closing this out. I'd rather not have any integration at all to maintain really, so changing right now doesn't make a lot of sense to me.