Ugh, if I change a node type or vocabulary machine name, the pathauto variables are not renamed, and will result in a loss of functionality. We're also blocked by another core issue: #876762: Modules have no way of knowing if vocabulary machine names are changed.

CommentFileSizeAuthor
#4 876768-pathauto-handle-bundle-rename-delete.patch9.68 KBdave reid
#3 876768-pathauto-handle-bundle-rename-delete.patch8.11 KBdave reid

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Perhaps until that core issue gets fixed we should roll back the change from vid to machine name?

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

We could but we would still have to address the issue of node type machine names being changed. Plus, the issue linked above is already RTBC. It's also an easy work-around by implementing a hook_taxonomy_vocabulary_presave().

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
StatusFileSize
new 876768-pathauto-handle-bundle-rename-delete.patch8.11 KB

Attached patch for review that:
1. Implements hook_field_attach_rename_bundle() to account for when entity bundles have their machine name changed.
2. Implements hook_field_attach_delete_bundle() to account for when entity bundles are removed and Pathauto should cleanup its variables.
3. Adds tests to ensure #1 and #2 work as desired.
4. Renames the variables 'pathauto_taxonomy_*' to 'pathauto_taxonomy_term_*' to match the 'taxonomy_term' entity type.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 876768-pathauto-handle-bundle-rename-delete.patch9.68 KB

And second time, fixing the one test failure to account for latest Token module element validation.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Version: 7.x-1.x-dev » 6.x-2.x-dev
Status: Needs review » Patch (to be ported)

Committed #4 to CVS
http://drupal.org/cvs?commit=467242

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

6.x-2.x and 6.x-1.x will still need to handle checking if node types are changed.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Version: 6.x-2.x-dev » 6.x-1.x-dev

Committed to 6.x-2.x: http://drupalcode.org/project/pathauto.git/commit/c3032d9

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Patch (to be ported) » Fixed

Committed to 6.x-1.x: http://drupalcode.org/project/pathauto.git/commit/f19d683

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Version: 6.x-1.x-dev » 7.x-1.x-dev

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.