Closed (outdated)
Project:
Drupal core
Version:
7.x-dev
Component:
Bartik theme
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
8 Aug 2010 at 10:23 UTC
Updated:
24 May 2013 at 18:54 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #1
Jeff Burnz commentedI could get to this soon, but if someone else wants to jump in a roll a patch ;)
Comment #2
nevergonetextarea patch
Comment #3
Jeff Burnz commentedThis can't be a fixed width, the textarea has to be fluid to account for different sidebar configurations.
I've seen this in a few places in Bartik so we must have a bug somewhere in the CSS that's causing this general problem.
Powered by Dreditor.
Comment #4
reglogge commentedIt's the left and right padding of 4px each in the textarea. Set these to 0px for IE7 and below in ie.css and the scrollbar is there.
The seemingly indented username stems from both the link (a.username) and the input element below being styles with width: 75%, float: right and padding: 4px. The padding doesn't take in IE6 & 7 (and other real browsers as well) for the link since its not rendered as a block. Adding margin-right: 8px to the link fixes this too.
Patch attached.
Comment #5
Jeff Burnz commentedThis looks good - I've checked in IE6, 7, 8, FF, Chrome - looks good both for logged in and anon comments.
I realise the zero horizontal padding is not the prettiest fix for IE6/7, but is the easiest fix at the moment. I think we have to run with it, because the alternative is either:
1 - hacky percentage overrides for both the width of the textarea and the padding - not liking this, its fragile
2 - dynamically setting the width (in pixels) based on the active sidebars - not a big fan of this either because it will take a lot of testing
I found another issue with the comment form labels in IE6 - can we try and fix this as well? If not then we can RTBC this now and get it in, then go for the label fix for IE6 in another issue - I leave it up to you, we're not supposed to creep scope like this but since we are so few managing many separate issues is really hard (read - I have re-roll so many patches every time one tiny patch gets committed...).
Comment #6
reglogge commentedI feel your pain regarding rerolling patches. The fix for the IE6 issue in #5 is easy enough: Just add
to ie6.css.
Patch attached. Note however :-( that this patch does not apply together with the patches in #660614: Remove #block-system-main dependency, fix font sizes, remove crufty CSS. So one of the two should go in first and then let's do a reroll of the other one. It's probably better to first get this one in.
Comment #7
Jeff Burnz commentedOK, lets go for it, looks good, tested and approved. I can't see another way out of this without some serious hacking on textarea widths, IE8+ support box-sizing so these old browsers will just have to have a no-padding experience.
Comment #8
reglogge commentedPostponing this one until #660614: Remove #block-system-main dependency, fix font sizes, remove crufty CSS lands. They don't apply both and the other issue is more important.
Comment #9
Jeff Burnz commented#6: 876960-6.patch queued for re-testing.
Comment #11
reglogge commentedThe new patch should apply now. It contains only the fix for the textarea width (and disappearing scrollbars) in IE7 and below since the other fixes don't seem to be necessary any more.
Comment #12
reglogge commentedRerolled the patch against current HEAD. This can also be backported.
Comment #13
droplet commentedComment #14
reglogge commented@droplet: any particular reason why you set this back to 7.x-dev?
Comment #15
droplet commentedno IE6 & 7 support in D8.
#1217788: Drop IE7 support in Drupal core
Comment #16
reglogge commentedHallelujah!
Comment #17
yashadev commentedComment #18
star-szr#11: IE-textarea-scrollbars-876960-11.patch queued for re-testing.
Comment #19
bryandrew19 commented#2: 876960-1.patch queued for re-testing.
Comment #20
aloyr commentedwill try to reroll this patch
drupalcon portland
Comment #21
parthipanramesh commentedSorry but the path has changed. It's themes/bartik/... now.
error: core/themes/bartik/css/ie.css: No such file or directory