Convert to drupal7

dereine, I'm unable to apply the patch, is it build for HEAD really?

No, I was able to apply to the 6--1 branch, so this patch is not for head. Darthclue, are you going to be able to review patches? instead of a great 60k patch perhaps we can go with smaller parts, a patch per file or something eassier to review for you. I'm interested in having this working on D7 also, so I'll contribute to the upgrade.

Do we start again (porting dereine's code) with HEAD or is HEAD broken or something?

dereine, I'd say to commit your patches as they, are even if they are 100kb or more, but I was asking the module mantainer to provide an eassier way to review the changes (60kb is a big patch). I saw you rolled the patch from 6--1, any particular reason? do you know if HEAD's current status is far from 6--1 branch?

ok, so, do you have any suggested plan?, lets begin with a clean HEAD setup?

If anybody wants the final result (tested slightly) for Drupal 7, here it is, attached. It is based on the latest 6.x version of the module.

not tested yet, but subscribing for later

Hi darthclue,

As per the module page "I expect to have this ready before 1 Jan 2012." regarding an upgrade path for advanced_menu - has this progressed any further yet? Will the code be in bookmarks, or advanced_menu? Also will advanced_menu provide similar functionality as bookmarks?

I notice there hasn't been any commits since March 2011: http://drupalcode.org/project/bookmarks.git/log

We may be available to help, but don't want to be re-doing anyone's work.

Thanks.

Hi again darthclue, any progress with this? I notice the git logs still aren't showing much. I know what it's like with finding the time to maintain contrib's, so don't feel too bad about it. We might try do things manually with some SQL queries.. I'll post back anything we think could be useful.

darthclue, I had trouble trying to find the bookmark functionality in advanced_menu, so ended up using the Flag module.

SQL used to convert bookmarks to flag module is as follows:

insert into flag_content (fid, content_type, content_id, uid, sid, timestamp) 
select
1,
'node',
substr(ml.link_path, 6), /* node id */
substr(ml.menu_name, 11), /* uid */
0,
NOW()
from menu_links ml 
left join users u on substr(ml.menu_name, 11) = u.uid 
left join node n on substr(ml.link_path, 6) = n.nid
where
substr(ml.link_path, 1, 4) = "node" and
substr(ml.menu_name, 1, 9) = "bookmarks" and
u.uid is NOT NULL and
n.nid is NOT NULL
ORDER BY substr(ml.link_path, 6) ASC

Thank you for the module for D7 at #14. I tested it and at the end at file bookmarks_public.module there may be a curly bracket missing.
Great work.

Ok, I need to take back the previous comment. The problem is that line 24 is a duplicate. Once you address that the module works properly.