paypal_payer table definition broken; install schema out of sync with updates

Thanks for the typo report (fixed by this commit: http://drupal.org/cvs?commit=41977)

Please note, I did not apply your patch as the column updates where added at update level 3 (run update.php).

These updates were made here:
http://cvs.drupal.org/viewcvs/drupal/contributions/modules/paypal_framew...

However, I have found there are a number of issues regarding the paypal_framework module that need attention. It appears Paypal's IPN specification has moved on significantly but this module has not (I just recently aquired maintainership). So, it's needing alot of work to fix these problems (main problem is ppf cannot handled multiple IPN messages, esp for {'txn_type'} = 'subscr_signup' which lacks an txd_id, used by ppf for it's primary key). The upshot of this is paypal_subscription.module cannot function (and anything else expecting multiple IPN data packets)

I'm working through these at the moment.

Correct, updates don't get run at install time. You must run "update.php" to pull in updates.

I admit, that's rather mad. I normally (in my install files) put in "schema detection" and run updates if I need to. The problem with Paypal_framework (PPF) is I have only just taken over maintainership of the module so I haven't put much effort into it yet.

However, there are more pressing issues regarding PPF:-

1. The framework is way out of step with the Paypal technical specification, it need's bringing right upto date, and that leads on to...
2. The current schema is problematic, it relies on all IPN packets having a unique txn_id code as that's the primary key for the paypal_log database table. However, that's no longer the case as can be found by reading the Paypal specification

In order to address these main points/bugs (not really bugs, just PPF hasn't moved with the times as though to say) will require a substantial database review. I did some prelimiary work today and my new code works just fine.

But, as they say, is this worth it? If you take a look at this thread you will see that Lee has put alot of effort into an alternative Paypal solution. Given this exists already and PPF requires alot of work it may well be best to retire PPF (esp for Drupal 5) and point people to Lee's new module (yet to be posted as a project).

These are my current thoughts, I'm a big believer in not duplicating work and Lee is well ahead, so why try to catch him?

I'm going to be recommending that people needing simple paypal support that don't want the heavy weight ECommerce module should look to the new lm_paypal module

This should be fixed in revision 1.5 (HEAD). Upgrading to that version should make your tables up-to-date in all situations.
Testing is welcome.