Currently, this module breaks with newer releases of Pressflow because Pressflow altered the core file_create_url() function in the following commit:

http://bazaar.launchpad.net/~pressflow/pressflow/6/revision/74.1.1#inclu...

The attached path accomplished two things:

  1. We send a full path including this files directory to file_create_url(). The allows the code to work with both stock Drupal and Pressflow.
  2. We also now use the same code to generate $image[$tid]->url for both taxonomy term images and the default image.
CommentFileSizeAuthor
fix_pressflow_incompatibility.patch1.39 KBbrianV

Comments

brianV’s picture

brianV commented

For more info, here is discussion of the changes to the file_create_url() function in Pressflow: https://bugs.launchpad.net/pressflow/+bug/597718

jdelaune’s picture

jdelaune commented
Status: Needs review » Reviewed & tested by the community

Thanks so much, was the going mad trying to figure out why it had stopped working!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

This patch should no longer be necessary thanks to #839282: Problems with shipped files and Drupal 6 file_create_url() behavior.

bibo’s picture

bibo commented

I got this problem after installing Pressflow, and have since been wasting hours to fix it. So glad I found this..

@Win Leers: Sorry, but how does that commit to the cdn-module fix this issue with taxonomy_image? :)

PS: the performance tips on your site are really great, thank you for them, and the module contributions!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

I think I tested back then with and without the patch by brianV after #839282: Problems with shipped files and Drupal 6 file_create_url() behavior and found it working in both cases. I'm not 100% sure anymore though. You should check again if that patch is still required. Maybe #3 was a brain fart :)

@bibo: glad you like my work :)

bibo’s picture

bibo commented

In any case, I can also confirm that this patch works (and saved my ass) :)

beanjammin’s picture

beanjammin commented

I also confirm that this patch worked for me. Thanks brianV!

naxoc’s picture

naxoc commented

This also does the trick for me :)

brianV’s picture

brianV commented

Marked #1043886: Module passes URL to getimagesize() instead of path as a duplicate of this one.

I can confirm that this patch is still needed with Pressflow 6.20.97 and Taxonomy Image 6.x-1.x-dev. Without this patch, Taxonomy Image is broken on Pressflow.

jarek foksa’s picture

jarek foksa commented

The patch also solves the issue for me. Tested with Pressflow 6.20.97 and Taxonomy Image 6.x-1.6.

j0nathan’s picture

j0nathan commented

Subscribing.

bibo’s picture

bibo commented
Status: Reviewed & tested by the community » Closed (fixed)
Issue tags: +Pressflow

An interesting turn of events: file_create_url() was changed in the last Pressflow version! See https://bugs.launchpad.net/pressflow/+bug/790092

David Strauss wrote on 2011-06-01: #3
I've reverted the change to file_create_url() in Pressflow. Back to the drawing board for combined HTTP/HTTPS support for the same cached page...

Changed in pressflow:
status: Triaged → Fix Released

I noticed this after some taxonomy images broke down when a large site was updated to Pressflow 6.22. Our taxonomy_image was patched with the patch in this issue, and had been working for over 6 months. We replaced our patched version with the latest dev-version of taxonomy_image, and the images started working again.

This rather complicated doublefix => site-break means that the patch shouldn't be applied anywhere. Thus I'm closing this issue (maybe not my call, but anyone can re-open if needed..).

sfyn’s picture

sfyn commented

For those who are having pressflow break taxonomy_image again, I have found the patch from #961834: Images have incomplete path fixes the issue.