Confirmation Message After Cart Update Quantity Incorrect [#878048]

The confirmation message (Cart quantity updated to N) always displays the quantity (N) of the first item if there are multiple items in the cart.

In other words, if I update the quantity of the second item to X, the confirmation message will refer to the first item's quantity N. I hope this is clear...

Comment	File	Size	Author
#7	amazon_store.confirmation_message_d7.patch	1.07 KB	rfay
#2	amazon_store_update_quantity.module.patch	911 bytes	the_g_bomb

Comments

Comment #1

the_g_bomb commented 10 October 2010 at 10:54

Confirmed

If 2 items are in the cart change the second item quantity and click update quantity. The quantity of the first item is displayed in the message.

This comes from around line 707 in the amazon_store.module

When the $result is returned the 0 index CartItem is used to update the message display message.

Changing the line to this should fix it.

<?php
  foreach ($results->Cart->CartItems->CartItem as $cartitem) {
    if ($cartitem->CartItemId == $cartItemId) $actual_quantity = $quantity > 0 ? (int)$cartitem->Quantity : $quantity;
  }
?>

I will create a patch that will check each CartItem to see if that is the cartitem that has been updated, then set the message as required.

Comment #2

the_g_bomb commented 10 October 2010 at 10:56

Status	File	Size
new	amazon_store_update_quantity.module.patch	911 bytes

Hope this helps

Comment #3

rfay

he,him

English

Palisade, CO, USA

commented 11 October 2010 at 13:16

Status:

Active

» Needs review

Comment #4

rfay

he,him

English

Palisade, CO, USA

commented 17 October 2010 at 18:58

+++ amazon_store.module	10 Oct 2010 10:53:53 -0000
@@ -704,7 +704,9 @@
+    if ($cartitem->CartItemId == $cartItemId) $actual_quantity = $quantity > 0 ? (int)$cartitem->Quantity : $quantity;

Same issue here - please don't use one-line conditionals.

Powered by Dreditor.