Posted by pwolanin on August 10, 2010 at 1:49am
5 followers
| Project: | Drupal core |
| Version: | 7.x-dev |
| Component: | base system |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
| Issue tags: | Performance |
Issue Summary
Follow up to #269911: Search result trimming should not fall inside HTML entities/tags.
Since PHP 5.0, html_entity_decode() supports utf8 in PHP >= 5.0, so it should be possible to use that instead of decode_entities() in Drupal 7.
Comments
#1
Here's a first quick pass. Do we want to maintain a wrapper function?
#2
That would be lovely. Let's see what the tests will say.
#3
The last submitted patch, 878408-entity-decode-1.patch, failed testing.
#4
A the failing tests were using the exclude parameter, which the patch proposes to remove.
#5
I suggest the following: keep the wrapper, as it is not trivial to get the arguments right, and rename it as drupal_html_entity_decode().
#6
@DamZ - why break the API more than needed at this point? Let's not rename the function.
#7
This is the same patch as #1 plus removing the irrelevant test case.
#8
The last submitted patch, 878408-entity-decode-7.patch, failed testing.
#9
huh- I find it hard to believe that's a real fail.
#10
#7: 878408-entity-decode-7.patch queued for re-testing.
#11
good to go.
#12
This looks good to go. I might add a "@todo: remove in Drupal 8" but I'm sure we'll remember to do that without the todo.
#13
Committed to CVS HEAD.
#14
Automatically closed -- issue fixed for 2 weeks with no activity.