This patch is compatible with D7-a6
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | mailchimp.module.811.patch | 1.7 KB | sonnykt |
| mailchimp.module.patch | 3.46 KB | sonnykt | |
| mailchimp.admin.inc.patch | 2.02 KB | sonnykt |
This patch is compatible with D7-a6
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | mailchimp.module.811.patch | 1.7 KB | sonnykt |
| mailchimp.module.patch | 3.46 KB | sonnykt | |
| mailchimp.admin.inc.patch | 2.02 KB | sonnykt |
Comments
Comment #1
sonnyktThis patch fixes mailchimp_cron() function in order to be compatible with D7-a6.
Comment #2
BenK commentedI'm happy to help with testing, but can you first let me know what issues you fixed in each of the three patches shown above?
Thanks,
Ben
Comment #3
sonnyktthe 7x-dev version isn't compatible with D7-a6, so I fixed a lot in order to make it work fine with the newest version.
Comment #4
BenK commented@jishan: Thanks for the clarification. I'm using the latest 7.x-dev version of D7. Have you tried to see if the patch will apply to the latest -dev version?
Also, what specifically wasn't compatible with D7-a6?
--Ben
Comment #5
BenK commentedHey jishan,
I've tested your various patches and I can confirm that they solve quite a number of issues. In particular, your patches some to solve the following reported issues:
* Sync Required Lists During Cron Results in Fatal Error
http://drupal.org/node/905570
* Fatal error when enabling list subscription block
http://drupal.org/node/876850
* Error messages on newsletter subscription page (mailchimp/subscribe)
http://drupal.org/node/876840
As a result, with the patches applied, I can successfully subscribe users to Mailchimp via either cron, the subscription block, or the newsletter subscription page. That's great!
The only thing that was weird with the patches were the patch headers... I had to manually selection the right file (mailchimp.module) in my patch program to get the patches to apply.
So nice work! I'll ping Lev, the module maintainer, to see if we can get these changes committed to the official branch...
Cheers,
Ben
Comment #6
BenK commentedComment #7
levelos commentedI partially applied these patches, although some of the work was already done, along with a few other changes. Thanks for the support.