In 5.x we had a preg_replace_callback(). In 6.x-1.x-dev we needed to pass $format and this was achieved with the e modifier approach.
However, current standards tell us not to use this modifier: http://drupal.org/node/750148.

See #855988: Get rid of preg_replace with /e in decode_entities() for the alternative.

CommentFileSizeAuthor
#3 chessboard-get-rid-of-e-878896-3.patch1.9 KBeric_a
#1 chessboard-get-rid-of-e-878896-1.patch2.2 KBeric_a

Comments

eric_a’s picture

eric_a commented
Status: Active » Needs review
StatusFileSize
new chessboard-get-rid-of-e-878896-1.patch2.2 KB
eric_a’s picture

eric_a commented
Status: Needs review » Needs work 
-function chessboard_filter($op, $delta=0, $format=-1, $text='') {
+function chessboard_filter($op, $delta = 0, $format = -1, $text = '', $cache_id = 0) {

This now has its own issue: #883126: Signature of chessboard_filter() missing $cache_id argument. Let's make this issue focus on the modifier.

+function _chessboard_filter_callback($matches = NULL, $set_format = NULL) {

I see no use case for the first argument being optional. In fact I find it confusing.

eric_a’s picture

eric_a commented
Status: Needs work » Needs review
StatusFileSize
new chessboard-get-rid-of-e-878896-3.patch1.9 KB

As per #2.

eric_a’s picture

eric_a commented
Status: Needs review » Fixed

Committed!

Status: Fixed » Closed (fixed)
Issue tags: -Novice

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Novice

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.