Hi,

Thanks for creating a project for this module.

However, the one i've been using here: http://drupal.org/node/684378#comment-3180266 (comment #49) works fine but not this module?

These are the errors in my log entries:

	Sagepay Server sent a not OK response. <pre>Array ( [VPSProtocol] => 2.23 [Status] => INVALID [StatusDetail] => 3139 : The DeliveryState format is invalid. ) </p>

	3139 : The DeliveryState format is invalid.

Also, install seems to fail as well. It works if you remove lines 117, 119 and 155

So i've revert back to the previous version that worked, which is http://drupal.org/node/684378#comment-3180266

Thanks,

Comments

leo pitt’s picture

leo pitt commented
Assigned: Unassigned » leo pitt
leo pitt’s picture

leo pitt commented
Status: Active » Needs review

I have just commited a fix for this issue to HEAD. When the dev snapshot appears after the nightly build, please try it out and let me know if the issue is resolved using it.

leo pitt’s picture

leo pitt commented

Actually, the install error is sufficiently major to warrant a new release outside of HEAD - this should be fixed in 6.x-1.2

onejam’s picture

onejam commented

Excellent, this version 6.x-1.2 works fine, thanks.

However, install script still has same issue on lines 117 and 119

error msg:

Warning: Call-time pass-by-reference has been deprecated in /sites/all/modules/ubercart/payment/uc_sagepayserver/uc_sagepayserver.install on line 117

Warning: Call-time pass-by-reference has been deprecated in /sites/all/modules/ubercart/payment/uc_sagepayserver/uc_sagepayserver.install on line 119
marcus178’s picture

marcus178 commented

I get the same error when running update.php

leo pitt’s picture

leo pitt commented

I have corrected the faulty pass-by reference calls.

The calls to db_change_field in uc_sagepayserver.install should not be passing $ret by reference, because it is already explicitly passed by reference in the function definition.

On servers where the PHP configuration has allow_call_time_pass_reference set to off, this results in the warning you've reported.

I have added this fix to HEAD, and it should be available in the 6.x-1.x-dev development snapshot, after that has rebuilt tonight.

Please try that out tomorrow and let me know if the issue has been resolved.

leo pitt’s picture

leo pitt commented
Status: Needs review » Fixed

Fixed in 6.x-1.3

onejam’s picture

onejam commented

Thanks for the new update. I can confirm version 6.x-1.3 is working as well.

leo pitt’s picture

leo pitt commented
Status: Fixed » Closed (fixed)