#853896: Type field is part of primary key but not marked as NOT NULL

CommentFileSizeAuthor
#5 head2head_module_installed.patch742 bytesJacobSingh
#2 head2head_module_installed.patch1.34 KBJacobSingh
#1 879606-1-search-schema.patch2.05 KBksenzee

Comments

ksenzee’s picture

ksenzee
she/her
commented
Status: Needs work » Fixed
StatusFileSize
new 879606-1-search-schema.patch2.05 KB

Committing the attached patch.

JacobSingh’s picture

JacobSingh commented
Status: Fixed » Needs review
StatusFileSize
new head2head_module_installed.patch1.34 KB

This breaks if the search module was never installed. I imagine we have others like this in head2head we've missed. Anyway, from now on we can use the helper function I added here.

David_Rothstein’s picture

David_Rothstein commented

You can just use drupal_get_installed_schema_version('search') != SCHEMA_UNINSTALLED, I think.

JacobSingh’s picture

JacobSingh commented

Oh, better.
I'll re-roll

JacobSingh’s picture

JacobSingh commented
StatusFileSize
new head2head_module_installed.patch742 bytes
David_Rothstein’s picture

David_Rothstein commented
Status: Needs review » Reviewed & tested by the community
JacobSingh’s picture

JacobSingh commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.