1,There is a warning:"The first parameter to t() should be a literal string. There should be no variables, concatenation, constants or other non-literal strings there. At t($output) in registration_role_with_approval.module on line 125. "
2,I think two strings displayed in UI should be t():
(1) $role_name.= " *needs administration approval"; //line 56
(2) '#title' => 'Choose a role', //line 63

CommentFileSizeAuthor
#2 registration_role_with_approval.zip9.49 KBtoni04

Comments

toni04’s picture

Issue summary: View changes
Status: Active » Fixed
toni04’s picture

StatusFileSize
new9.49 KB
toni04’s picture

Status: Fixed » Needs review
tamerzg’s picture

Status: Needs review » Fixed

Thanks just released into 1.2

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.