With the entities changeover, _all_ entity objects should be created via a call to VersioncontrolBackend::buildObject(), as the backends now act as central factories with mappings between a string 'type' (e.g., "branch", "repository") and the actual class to be used ("VersioncontrolGitBranch", "VersioncontrolGitRepository"). The factory in the backend class is likely to get more complicated as time goes on, so all the more important that we make sure we run all our logic through there.

Comments

sdboyer’s picture

Priority: Normal » Critical
marvil07’s picture

Just to mention that git grep new is a good start.

sdboyer’s picture

Issue tags: +git sprint 2

This, and other cleanup issues, go into sprint 2

chrisstrahl’s picture

Assigned: Unassigned » sdboyer
sdboyer’s picture

Status: Active » Fixed

All finished up, just needs reintegration.

sdboyer’s picture

Title: Make all entity object instantiations pass through VersioncontrolBackend::buildObject() » Make all entity object instantiations pass through VersioncontrolBackend::buildEntity()

Updating title, since the method name has been changed.

webchick’s picture

Title: Make all entity object instantiations pass through VersioncontrolBackend::buildEntity() » Make all entity object instantiations pass through VersioncontrolBackend::buildObject()
Status: Fixed » Closed (fixed)

Verified.

webchick’s picture

Title: Make all entity object instantiations pass through VersioncontrolBackend::buildObject() » Make all entity object instantiations pass through VersioncontrolBackend::buildEntity()

  • Commit c45966c on repository-families, drush-vc-sync-unlock by sdboyer:
    Issue #879866: Make all entity object instantiations pass through...

  • Commit c45966c on repository-families by sdboyer:
    Issue #879866: Make all entity object instantiations pass through...