It would be great if this module supported the ability to place the player.swf and audio-player.js files into a directory of my own choice, I prefer to have all my external libraries in a sites/all/libraries directory.

I also don't like how this module has to check for the files on every page load, that really the job of hook_requirements()

Attached is a patch to address these issues.

CommentFileSizeAuthor
#5 mp3player-880050-5.patch4.6 KBjoestewart
#4 880050-libraries.patch4.59 KBjoestewart
mp3player.patch4.86 KBunivate

Comments

univate’s picture

univate commented
Status: Active » Needs review
dkingofpa’s picture

dkingofpa commented

Used the patch with 1.x-dev. Works as expected. Thanks for saving me some time!

gorbeia’s picture

gorbeia commented

This patch makes 'sites/all/modules/mp3player/mp3player' the default path but the module can be installed in other directories. It makes more sense to use drupal_get_path('module', 'mp3player') instead.

joestewart’s picture

joestewart commented
StatusFileSize
new 880050-libraries.patch4.59 KB

rerolled patch as per #3.

joestewart’s picture

joestewart commented
StatusFileSize
new mp3player-880050-5.patch4.6 KB

maybe without my typos this time.

joachim’s picture

joachim commented
Status: Needs review » Needs work

Powered by Dreditor.

+++ ./mp3player.module	2010-12-02 10:55:56.000000000 -0600
@@ -147,6 +147,13 @@ function mp3player_players($pid = NULL) 
+      '#default_value' => variable_get('mp3player_library_path', drupal_get_path('module', 'mp3player')) . '/mp3player'),

Too many closing )s here, and not entirely sure what is meant.

Also, as a follow-on, there's #936032: Move drupal_add_js to theme function, in which the drupal_add_js() calls should be moved to the theme function rather than be always loaded in hook_init().

Powered by Dreditor.

jdelaune’s picture

jdelaune commented
Status: Needs work » Fixed

Committed to dev branch. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.