search-index never completes, but admin/settings/search shows site as 100% indexed

Are you sure that drush is setting your base_url correctly for you? For example, drush will work just fine if you use --uri=default to identify your site, but some modules might prefer (or demand) that you instead use --uri=mydrupalsite.org. (This presumes that your site it http://mydrupalsite.org, and you store your settings file at sites/default/settings.php; adjust for your particular values).

Normally Drupal will always set your base_url correctly based on the info sent in the headers from the web browser, but drush simulates these headers, so you need to tell drush accurately what your site should be called.

I just ran into this as well, using Advanced Help in Drupal 7 and the culprit seems to be a combination of:

a) Advanced Help search indexing is disabled.

b) drush_search_status() does not filter disabled search modules when generating its count.

c) advanced_help_search_status() does not return 0 if it is disabled.

d) _drush_core_search_index() tries, therefore, to iterate over records that are never returned, because it runs while $count > 0.

There are two possible fixes here:

1) Fix drush:

function _drush_core_search_status() {
  $remaining = 0;
  $total = 0;
  $active = variable_get('search_active_modules', array('node', 'user'));
  if (drush_drupal_major_version() >= 7) {
    foreach (module_implements('search_status') as $module) {
      if (!in_array($module, $active)) {
        return;
      }
      $status = module_invoke($module, 'search_status');
      $remaining += $status['remaining'];
      $total += $status['total'];
    }
  }

With a similar correction for D6.

2) File issues / clarify the documentation of hook_search_status() so that modules that are disabled always return 0.

Ref: http://api.drupal.org/api/drupal/modules--search--search.api.php/functio...

Given that Drupal core blindly returns a value here, I think drush has to fix the problem. (See http://api.drupal.org/api/drupal/modules--node--node.module/function/nod...)

I think this may be the same issue I saw a while ago - http://drupal.org/node/652894#comment-2387494

It's because Drush is doing the indexing in subprocesses, and the Realname count is coming from a static variable read by the parent Drush process. So it never changes. (That's a rough summary - that initial report is pretty old, but as far as I can tell, it's still like that.)

Note also that user.module DOES NOT store data in {search_data} so is always fully indexed. User module simply runs SQL queries on the {user} table. (Which is bad.)

See #1101668: User module does not use Search APIs fully

The code at #7 seems to work for me

I've made this into a patch against branch pear-7.x-4.x

Hard to tell WTF is going on here. Do we need to 'return' out of that loop (#7) or continue (#10)? Would be great if someone reviewed this.

I tried it with return as posted in #7 - the search-index returned very quickly without finishing the index ...

Apologies - I forgot I'd made this change when I said I'd rolled the above code to a patch.

It looks like it ought to be a return
The loop says

for each module which has hook_search_status (if it's active) run hook search_status

It seems that module_implements() returns modules which implement a hook - even if they are inactive.

We want to ignore these - but not subsequent modules so continue seems correct to me

I don't understand the purpose of $total and $remaining here - they don't appear to be used - but don't do any harm.

I took a look at how the the core search module was calculating the remaining items and copied that. My issue was with hook_search_status in the advanced_help module as in #7.

this works for d7 and d6?

@moshe weitzman

My patch in #13 fixes the loop in D7. If you look at the code for _drush_core_search_index() you'll see it only calls update_index for modules in the search_active_modules variable. So my patch only looks for remaining items to index for those same modules.

function _drush_core_search_index() {
  list($remaining, ) = _drush_core_search_status();
  register_shutdown_function('search_update_totals');
  while ($remaining > 0) {
    drush_log(dt('Remaining items to be indexed: ' . $remaining), 'ok');
    // Use drush_backend_invoke() to start subshell. Avoids out of memory issue.
    $eval = "register_shutdown_function('search_update_totals');";
    if (drush_drupal_major_version() >= 7) {
      foreach (variable_get('search_active_modules', array('node', 'user')) as $module) {
        $eval .= " module_invoke($module, 'update_index');";
      }
    }
    else {
      $eval .= " module_invoke_all('update_index');";
    }
    drush_backend_invoke('php-eval', array($eval));
    list($remaining, ) = _drush_core_search_status();
  }
}

I did try things out with realname in D6. realname is checking the status by looking at the realname_last_index variable. However, when processing the index in a loop the cached value is returned and not the value which is updated by the index function. If you ctrl-c then restart indexing drush will show the newly updated indexing value.

I also checked if there was a difference between modules being enabled or disabled and didn't find any troubles.

Committed #13, that fixes the case for drupal 7.

@brad.bulger idea for preventing infinite loop is still needed. http://drupal.org/node/652894#comment-2387494

Is this fixed by http://drupal.org/node/1403042 ?

That patch hasn't been applied to Drush 7.x.5.

Drush still ignores these settings.

Backported #13. Will be in 4.6.

Problem still exists in drush 7.x-5.8

Duplicates:
#985778: search-index does not process
#955736: drush search-index fails

Follow-up: #1824510: Fail if search-index gets into an infinite loop

Updated issue summary.