Closed (won't fix)
Project:
Drupal.org CVS applications
Component:
new project application
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
12 Aug 2010 at 07:41 UTC
Updated:
14 Apr 2019 at 11:17 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
kelnaj commentedComment #2
avpadernoHello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review the code, pointing out what it needs to be changed.
As per requirements, the motivation message should be expanded to contain more features of the proposed project. For themes, it should include also a screenshot of the theme, and (when possible) a link to a working demo site using the proposed theme; for modules, it should include also a comparison with the existing solutions.
Comment #3
EgonO commented+1 subscribe
would be great to have this module, i will try it on one of my productions-sites ;)
Comment #4
EgonO commentedok, first things: on settings-page i cant change the version, it always switchs back to for example IE6, i want to notify everthing until IE10...
on IE6 the banner doesn't show at all...
Comment #5
manuel garcia commentedThe module's js is not using Drupal.behaviours.
Also, this function seems unnecessary.
Overall the js file is not eligible to be contributed, this and the fact that it has been 7 weeks without response, is why I'm setting this to won't fix.
Comment #6
manuel garcia commentedCVS maintainer stil needs to have his say =)
Comment #7
avpadernoI agree that a single JavaScript file doesn't make a module. We need more code to approve an application.
Comment #8
avpadernoPlease read the following links as this is very important information about CVS applications.