CVS edit link for kelnaj

I am using drupal now since 1,5 years and used and developed some modules and themes in the past time.
Now i wish to give the community something back so i started this module.
My module is an integration of http://browser-update.org into drupal.
Nearly all available settings can be configured over an admin form page.

Browser-update.org provides an js script which warns users which use a certain browser (e.g Internet Explorer 6) that their browser is outdated and how to upgrade to a newer version.

CommentFileSizeAuthor
#1 browser-update.zip3.37 KBkelnaj

Comments

kelnaj’s picture

Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new3.37 KB
avpaderno’s picture

Status: Needs review » Needs work
Issue tags: +Module review

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review the code, pointing out what it needs to be changed.

As per requirements, the motivation message should be expanded to contain more features of the proposed project. For themes, it should include also a screenshot of the theme, and (when possible) a link to a working demo site using the proposed theme; for modules, it should include also a comparison with the existing solutions.

EgonO’s picture

+1 subscribe

would be great to have this module, i will try it on one of my productions-sites ;)

EgonO’s picture

ok, first things: on settings-page i cant change the version, it always switchs back to for example IE6, i want to notify everthing until IE10...

on IE6 the banner doesn't show at all...

manuel garcia’s picture

Status: Needs work » Closed (won't fix)

The module's js is not using Drupal.behaviours.

Also, this function seems unnecessary.

function checkIfFalse(checkvar){

  if(checkvar == "false" || checkvar == "0") return false;

  return true;

}

Overall the js file is not eligible to be contributed, this and the fact that it has been 7 weeks without response, is why I'm setting this to won't fix.

manuel garcia’s picture

Status: Closed (won't fix) » Needs work

CVS maintainer stil needs to have his say =)

avpaderno’s picture

Status: Needs work » Closed (won't fix)

I agree that a single JavaScript file doesn't make a module. We need more code to approve an application.

avpaderno’s picture

Component: Miscellaneous » new project application
Issue summary: View changes

Please read the following links as this is very important information about CVS applications.