Your openid_provider_user_url() works with user/UID/identity.

Your openid_provider_pathauto_bulkupdate() mentions a different 'src' URL: user/UID/openid. (Which results in [depends on your pathauto settings. I am guessing you don't need detailed results, since I guess this is a leftover mistake from sometime before someone spotted that user/UID/openid is used by openid.module?])

A second thing: your default pathauto replacement pattern is users/[user-raw]/openid. Do you also want to replace that with users/[user-raw]/identity ? The '/openid' thing clashes with the path used by openid.module, if Sub Path URL Aliasing (subpath_alias.module) is enabled.

CommentFileSizeAuthor
openid_provider.pathalias.patch1.36 KBroderik

Comments

grub3’s picture

grub3 commented

CAST is wrong, have a look at PostgreSQL fix.

roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented
Status: Needs review » Reviewed & tested by the community

@grub3: yes, "CAST is wrong" (i.e. not fixed in this patch yet), because I split two fixes over two patches.

@walkah: I'm going to cheat now, by setting RTBC.

The point of this patch is not that it needs testing ny others. It needs your review.
The point is hopefully you will think "hmm yeah that's right, I decided to use different paths at some point, and apparently didn't propagate that change to the pathauto related code". (At least that's what it looks like, to me... I could be wrong, but...)

anarcat’s picture

anarcat commented

I agree with the analysis here, this seems sound and just like a little something that was forgotten.

anarcat’s picture

anarcat commented
Status: Reviewed & tested by the community » Fixed

patch committed and pushed to the 6.x branch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.