I was implementing this module with ajax comments, and had to comment out some gotos causing the ajax comments not to work properly. Is there a way to configure this module to work with ajax comments or will a hack be needed to make this work with that module. If it helps I can provide my patch that helped me get this to work with ajax comments, I was just wondering if theres a better way or planned future support.

CommentFileSizeAuthor
#3 spam-881573.patch4.42 KBfotuzlab
#1 spam-881570.patch4.14 KBmdorrell

Comments

mdorrell’s picture

Version: master » 6.x-1.0
Status: Active » Needs review
StatusFileSize
new4.14 KB

Try using this patch. This takes out the drupal_gotos, and uses the form_set_error to give messages to the user. Something this module should have done anyways.

tnanek’s picture

I'm still in early development stages of my site when I tried to apply this patch, and it wouldn't apply automatically following the steps at http://drupal.org/patch/apply - I went through and applied it by hand though since it does look correct etc, I shall post back if I experience any problems with it at a later point.

fotuzlab’s picture

StatusFileSize
new4.42 KB

The patch works really well. Great work by mdorrell.
Just modified set_form_error() so that it displays the custom message(defined in the text area in Spam UI) rather than hard coded message in the earlier patch.

gnassar’s picture

Status: Needs review » Needs work

I like the idea of this patch a lot -- but I think it may break the "spam feedback" functionality for those who want to prompt users who submitted spam to request moderator action.

Also, the last few changes in the patch seem to modify cases where there is no spam-flagging error -- for example, administrators manually setting content as spam/not spam from the admin pages.