Instead of upgrading, i reinstalled aegir (0.4-alpha11, I had 0.4-alpha08).
During the installation process I got:
WD php: Parameter 1 to hosting_site_nodeapi_site_presave() expected to be a reference, value given in /var/aegir/hostmaster-0.4-alpha11/includes/module.inc on line 483.
Now I get these warnings every time I verify a site...
Php 5.3 related?

Comments

nofuseto’s picture

nofuseto commented

Following http://drupal.org/node/761498, i changed:

/var/aegir/hostmaster-0.4-alpha11/profiles/hostmaster/modules/hosting/site/hosting_site.nodeapi.inc

line 134:

function hosting_site_nodeapi_site_presave(&$node) {

to:

function hosting_site_nodeapi_site_presave($node) {

which seems to have fixed the issue.
Hope I didn't mess up anything:)

adrian’s picture

adrian commented
Status: Active » Fixed

the issue is actually upstream.

we are using module_invoke_all, which doesnt pass references to the functions. We need to give the node object as a reference because some of the nodeapi operations need to modify the object.

[master f5fae9c] Pass node as reference to nodeapi functions. #882210
1 files changed, 16 insertions(+), 1 deletions(-)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 5ef2214 on dev-dns, dev-log_directory, dev-migrate_aliases, dev-multiserver-install, prod-koumbit, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x by adrian: 
    Pass node as reference to nodeapi functions.  #882210

  • Commit 5ef2214 on dev-dns, dev-log_directory, dev-migrate_aliases, dev-multiserver-install, prod-koumbit, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x by adrian: 
    Pass node as reference to nodeapi functions.  #882210