Query results cache does not track distinct result sets

Perhaps I am looking at the wrong thing. This is views_plugin_cache::get_results_key

function get_results_key() {
    global $user;

    if (!isset($this->_results_key)) {
      $key_data = array(
        'build_info' => $this->view->build_info,
        'roles' => array_keys($user->roles),
        'super-user' => $user->uid == 1, // special caching for super user.
        'language' => $GLOBALS['language'],
      );
      foreach (array('exposed_info', 'page', 'sort', 'order') as $key) {
        if (isset($_GET[$key])) {
          $key_data[$key] = $_GET[$key];
        }
      }

      $this->_results_key = $this->view->name . ':' . $this->display->id . ':results:' . md5(serialize($key_data));
    }

    return $this->_results_key;
  }

both query and apachesolr_params aren't in there.

Does this mean we need to override get_results_key in the cache plugin?

Things may have moved on a bit in views since this bugs was raised. I have had more luck adding a method get_cache_info() to the apachesolr_views_query object. Get_results_key() now calls this and if not present it will not cache.

If I get some robust code in there I'll submit a patch.

Attached is patch, first patch I have done from git so apologies if formatting is wrong.

This is not working on 7.x, a views cache plugin class needs to be implemented.

I took the liberty of creating the cache plugin and doing a get_cache_key for this module, since apachesolr_views' query variable is not an object, but a string.

I mistakenly triggered a test build, but there are no tests for this module... Moving back to review

Looks fine.

But I almost never use views cache, and I am not using this module currently, so will wait for other reviewer to RTBC.

Updating the patch since the typehint broke the fix