Closed (fixed)
Project:
Sports Pickem
Version:
6.x-1.12
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
14 Aug 2010 at 03:33 UTC
Updated:
3 Apr 2012 at 02:31 UTC
Jump to comment: Most recent file
Just wondering if work had been started on a NFL 2010 gameset. If not, I can probably create it and submit a patch. Nice module!
| Comment | File | Size | Author |
|---|---|---|---|
| #17 | small_logo_picks_screen.png | 123.31 KB | jvandervort |
| #15 | NFL_2010.gameset.txt | 116.43 KB | jvandervort |
| #14 | NFL_2010.gameset.txt | 112.11 KB | tlreiners |
| #3 | NFL_2010.gameset.txt | 124.53 KB | justintime |
Comments
Comment #1
tlreiners commentedI started on the 2010 gameset (I did last year's), but ran into a bug and have been waiting to see if jvandervort releases an update (he was very responsive last year). I haven't added any games, but I do have the 2010 week data finished. I'll post it here if you want to use it as your starting point.
Comment #2
justintime commentedI found a CSV schedule and did some sql magick on that to make short work of the process. I'm all done! Once I do some QA, I'll post it.
Comment #3
justintime commentedWhat the heck, I'll just post it and you can help me look it over :) I'm Central timezone.
Comment #4
justintime commentedBTW: Here's the link for the csv file: http://mysportscal.com/nfl.html
Comment #5
tlreiners commentedI'll upload it and do some week and game QA. I'll let you know if I find anything.
Thanks again.
Comment #6
tlreiners commentedwould you be willing to work a little more SQL magic to make a Eastern timezone version?
I'm also in the central timezone, but I used an Eastern timezone last year and changing the global pickem settings to central will throw off last year's data.
Comment #7
justintime commentedJust run this SQL (assuming you're running MySQL and you don't have a table prefix):
Comment #8
tlreiners commentedI went ahead and truncated all of last years pickem tables...then started from scratch and ran the SQL statement. I'll do the QA tomorrow and post the results.
Comment #9
tlreiners commentedI just finished the week by week and game by game review...and all looks good. I'll be adding the playoff weeks (with tentative dates based on last year's schedule) and posting the exported gameset.
Comment #10
tlreiners commentedokay...found a couple minor issues with the gameset:
1. I set the game scores to NULL...after import they were defaulted to 0 / 0 which makes everything appear as ties.
2. I renamed a couple team abbreviations to KC and SD instead of KAN and SAN.
3. I also needed to run the 'update pickem_games set gametime = date_add(gametime, interval 1 hour)' for the week table(not applicable for the central time geameset).
4. small logo location points to a non-existant directory so I emptied the fields out in the database.
I'll post the gameset after I add the playoff info.
Comment #11
jvandervort commentedGo ahead and post what you've got. I'm not sure we want tentative playoff weeks, but we'll check it out.
There is a risk for an unsuspecting site admin to just add the games and not fix the weeks start date which may have either the incorrect date or incorrect time. This would throw off the pick lockup date/time. Just a FYI I guess.
Relating to the timezone, I'd also like to keep the timezone to eastern so that we match
http://www.nfl.com/schedules
It helps for QC and is mostly official:)
Good to have you guys helping, thanks again.
Comment #12
justintime commented@jvandevort, I really haven't looked the module over too closely, but I have a thought:
Why not store the gametimes in the DB in GMT, and then simply convert based upon the selected timezone with PHP on the way in and out?
This would allow me to change timezones in the UI without having to touch any data. It would also make an EDT user's gameset export work for people in CDT.
If it's a viable feature request, I can make a new issue for it.
Comment #13
jvandervort commentedThe main reason is the NFL schedule is in the Eastern time zone and includes daylight saving time (DST).
The schedule doesn't explicitly show it, but games after Nov 7 are an hour later when measured against GMT.
As designed the module handles this by setting itself into a matching timezone which also has DST.
I think this is the best solution, but I'm open to suggestions. I think entering and checking the game times is easier when they all match exactly what the nfl posts on its website.
Comment #14
tlreiners commented2010 EDT gameset attached...no playoff data. I reviewed the weeks and games for accuracy and everything checks out...although an extra set of eye's wouldn't hurt.
Comment #15
jvandervort commentedQC:
- Weeks matched Games first start time.
- Weeks matched NFL schedule.
- All Teams bye weeks matched NFL schedule.
- Various games choosen at random matched NFL schedule.
Fixes:
- Renamed Bucaneers to Buccaneers in team list.
- Added small logo file names to team list.
If no one has anymore corrections in a couple days, I'll add this to the CVS release.
Comment #16
tlreiners commentedI just uploaded the updated gameset...looks good!
Question:
Where are the small_logo used? I don't see logos used anywhere on my site.
Thanks again for a great module!!!
Comment #17
jvandervort commentedThe location for the small logos is currently only the pick screen.
Picture attached.
Comment #18
jvandervort commentedCommitted to dev.