By mdbrenner on

Hi everyone,

I am a fairly new Drupal user, working for a small nonprofit in the US. I've really enjoyed learning Drupal, and see an enormous amount of possibility for our organization once the migration process from our old site is complete. But some things about Drupal do make you want to pull your hair out.

I have one such problem right now with the paypalpro module in the ecommerce suite. We have a Website Payments Pro account with paypal, which should allow us to process credit cards onsite. Our SSL certificate is installed and all the settings I believe are configured correctly, but when we try and process credit cards through the store, the user ends up at a page displaying the following error

warning: Invalid argument supplied for foreach() in /home/labornot/public_html/modules/ecommerce/contrib/ecivicrm/ecivicrm.module on line 49.

warning: Cannot modify header information - headers already sent by (output started at /home/labornot/public_html/includes/common.inc:384) in /home/labornot/public_html/modules/ecommerce/contrib/paypalpro/paypalpro.module on line 827.

Despite the error message, the credit cards are successfully processed in paypal, but users think they made a mistake and are likely to go back and try again.

I've looked pretty hard for a similar issue on drupal.org, but with no luck. Is there anyone who has worked with the paypalpro module who might have some ideas as to what is going on here? Many thanks in advance.

⋅ Categories: Drupal 4.6.x

Comments

mwu’s picture

mwu commented

I suggest you post line 49 here.

mdbrenner’s picture

mdbrenner commented

Here are lines 825-843 of paypalpro.module

   // transaction complete, return to http://
    $goto = str_replace('https://', 'http://', $base_url);
    header("Location: $goto" . url(strtr(variable_get('paypalpro_success_url', 'store/transaction/view/%txnid'), array('%txnid' => $txnid))));
    exit();
  }
  else {
    // transaction failed
    if (strpos($exec_return, 'Failure')) {
      $errors = paypalpro_get_errors($exec_return);
      foreach ($errors as $error) {
        paypalpro_set_error($error);
      }
    }
    else {
      $output .= drupal_set_message('<b>Communication error.</b>  Failed to connect to the authentication server.  Please try again later.', 'error');
    }
    paypalpro_goto($edit);
  }
}
mdbrenner’s picture

mdbrenner commented

Here are lines 46-64 of ecivicontribute.module

      // build messages for activity history
      $donation = '';
      $transaction = '';
      foreach ($txn->items as $item) {
        if ($donation) {
          $donation .= ', ';
        }
        if ($transaction) {
          $transaction .= ', ';
        }

        if ($item->ptype == 'donate') {
          $type = t('donation');
          $donate = 1;
        }
        else {
          $type = $item->ptype;
          $donate = 0;
        }
mdbrenner’s picture

mdbrenner commented

Thanks to Darren Oh for the suggestion that I disable displaying error messages on the screen. Now the credit card processing works seamlessly as far as the user can tell. I would still like to sort out the source of the error msg, but now I have a little more breathing room to do so.

As an aside, I just discovered that if I try to log into paypal and pay with a credit card that way (what paypal boasts of as a way not to share your credit card info with the local site) I get a validation error.

Validation error, please try again. If this error persists, please contact the site administrator.

In this new case the credit card transaction is not processed, and it seems clear that there is something going wrong with the handshake between paypal and my site. I will keep posting updates and more info as I work through the bugs.