Hi all,

Just wanted to help out with some feedback and testing I gathered from the following versions:

6.x-1.0-alpha5 - I updated to this today and the one thing I noticed was that all overrides that I set in my custom mail.css for my newsletter were not respected when the newsletter was sent. Tested on Gmail, Apple Mail and Hotmail.

6.x-1.0-alpha3 - I reverted back to this version which I had before and all was good again all css overrides were respected on Gmail, Apple Mail and Hotmail.

My setup is exactly the same and I am using the compressor module for the CSS.

So my conclusion is something slightly changed in versions alpha 4 & 5 which are disallowing css overrides. From my research it seems the Compressor module is rather complex but this was not an issue as of alpha version 3.

I hope this helps, unfortunately I am not a developer so I am unable to supply any further information. I do think this is a very common work flow for themers so if we could add this back in it would be awesome.

CommentFileSizeAuthor
#7 mimemail.882960_01.patch1006 bytessgabe
#5 newsletter-source.html_.zip4.77 KBglynster
#2 mail.css_.zip996 bytesglynster

Comments

sgabe’s picture

sgabe commented
Priority: Major » Normal

On the release note you can see the committed patches and identify which one cause you problems.

There were two issues which could be related:

However this feature still should work in alpha5, I never intended to remove it. I just tested again and it works for me just fine.

Please take a try again and provide more information here, attach your mail.css and the source of the messages (both good and bad).

glynster’s picture

glynster commented
StatusFileSize
new mail.css_.zip996 bytes

I reviewed your 2 node references but did not see the connection.
I also applied your patch here: http://drupal.org/node/796510 as this seemed to be more related to my issue however this caused pretty much all the CSS to be removed.

I currently have the latest alpha 5 version and attached is my CSS.

glynster’s picture

glynster commented

Also that same CSS file works perfectly on alpha version 3
As soon as I upgrade or alpha version 4 or 5 .newsletter a is applied over .newsletter .footer a for example.

sgabe’s picture

sgabe commented

Please attach the source of the messages and a screenshot that shows how the message should look like.

There were two similar issues in alpha4:

Note if you have inline style attributes in the template files those were overwritten before but will stay intact in alpha4-5 on account of #700996: Custom inline style properties overwritten when using CSS Compressor.

glynster’s picture

glynster commented
StatusFileSize
new newsletter-source.html_.zip4.77 KB

Attached is the source and here is a link to the online version which renders as it should:
http://www.danceplug.com/newsletters/2010/08-15-10

sgabe’s picture

sgabe commented

Please attach the complete source of the e-mail message and/or send me a test message to the sgabe@freemail.hu address.

sgabe’s picture

sgabe commented
StatusFileSize
new mimemail.882960_01.patch1006 bytes

I could reproduce this bug and the #700996: Custom inline style properties overwritten when using CSS Compressor causing this, which aims to preserve the existing inline values by overwriting the new style with the old one. The problem is that this approach ignores the CSS style precedence and the first value for a property will overwrite the second one with higher specificity. I will revert this commit and reopen the issue to find another solution.

Please try the attached patch and report back.

glynster’s picture

glynster commented

Good news on my end this resolves the issue for me. All CSS overrides are now respected. I actually do not use any inline CSS as I think this completely voids the reason for using the CSS Compressor module. It is also an awesome tool in keeping your online version free of all the the inline CSS, not to mention on update to the mail.css and your newsletter is updated. Not too sure why people would want to do both.

Again thank you for this patch as my problem has been fixed completely by applying this patch to the Alpha 5 version.

sgabe’s picture

sgabe commented
Status: Active » Reviewed & tested by the community

Thanks for your report. In the next release this will be fixed.

glynster’s picture

glynster commented

Thank you so much for your time and energy.

sgabe’s picture

sgabe commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.