the data_taxonomy_data_insert function starts like:

function data_taxonomy_data_insert($record, $table_name) {
  if ($info = data_taxonomy_get_info($data_table)) {

$data_table needs to be replaced with $table_name for this to work.

CommentFileSizeAuthor
#3 883090-3_static_cache.patch1.13 KBalex_b

Comments

batje’s picture

batje commented
Title: typo in data_taxonomy_data_insert » small typos in data_taxonomy_data_insert

The same typo as in the main issue appears in data_taxonomy_data_update

and removing the

static $info;

from the data_taxonomy_get_info function greatly enhances the usability when using more than one table!

batje’s picture

batje commented
Priority: Normal » Major

Plus, changing

db_query("DELETE dt FROM {data_taxonomy} dt JOIN {term_data} td ON dt.tid = td.tid WHERE td.vid = %d", $vid);

in the data_taxonomy_data_update function to

db_query("DELETE dt FROM {data_taxonomy} dt WHERE dt.id = %d AND data_table_name = '%s'", $id, $table_name);

prevents all data + terms links from a dictionary being deleted when you update 1 data record.

(increased the priority )

alex_b’s picture

alex_b commented
Title: small typos in data_taxonomy_data_insert » Fix caching in data_taxonomy_get_info()
StatusFileSize
new 883090-3_static_cache.patch1.13 KB

Ok, this is a series of issues.

- The initial issue reported is fixed in alpha13.
- Patch for data_taxonomy_get_info() attached
- #2 warrants its own issue.

Thanks for reporting.

alex_b’s picture

alex_b commented

Moved #2 to #925390: Data Taxonomy: Limit deletion to item id, data table name

alex_b’s picture

alex_b commented
Status: Needs review » Fixed

#3 is committed, thank you:

http://drupal.org/cvs?commit=428978

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.