It would be useful to have a function to programatically suppress the output of the toolbar menu. This would be used in cases such as when using the modal frame api (i.e. you don't want a toolbar in a modal window). Both the admin menu and admin modules already have a similar functionality.

This patch adds a new function toolbar_suppress() which is checked in hook_footer and doesn't populate the footer if the toolbar is meant to be suppressed.

CommentFileSizeAuthor
#8 toolbar-programatically-suppress-toolbar-883134-2.patch802 bytesdankh
#5 toolbar-programatically-suppress-toolbar-883134.patch479 bytesdankh
toolbar_suppress.patch751 byteshadsie

Comments

dankh’s picture

dankh commented
Status: Needs review » Reviewed & tested by the community

Great idea, thank you ! I have just added one more check in the function :

if (!empty($set) && $suppress === FALSE) {
  $suppress = TRUE;
}
dankh’s picture

dankh commented
Status: Reviewed & tested by the community » Fixed

http://drupal.org/cvs?commit=408850

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
Category: feature » bug
Status: Closed (fixed) » Active

CSS and JS is still attached even if menu is suppressed.

dankh’s picture

dankh commented
Assigned: Unassigned » dankh
Status: Active » Needs review
StatusFileSize
new toolbar-programatically-suppress-toolbar-883134.patch479 bytes

Confirmed. Please review and test patch.

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
Status: Needs review » Needs work

Unfortunately the problem with detecting for _suppress() in hook_init() is that if the module trying to invoke the suppress is weighted after Toolbar it won't be able to call suppress before it's checked for.

If the CSS and JS need to be added in hook_init() then they will need to be done in a way that they don't do anything unless the the content added during hook_footer() is present.

dankh’s picture

dankh commented
Title: Programatically suppress toolbar output » Programatically suppress toolbar output
Status: Needs work » Needs review

Ok, I get your point. hook_preprocess_page is executed before hook_init. So I moved the css and js includes in hook_preprocess_page this way regardless the module weight the suppress will work. I have tested already even with weight tweaking. Please review and test.

dankh’s picture

dankh commented
StatusFileSize
new toolbar-programatically-suppress-toolbar-883134-2.patch802 bytes

Comment preview doesn't work with attachments so again here is the patch.

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
Status: Needs review » Reviewed & tested by the community

Looks good. Marking as RTBC.

Now Admin, Admin Menu and Toolbar can all live in unison via the Administration Menu select module :)