Scheduler Workflow patches

+1, this integration is needed.

How does it relate to this similar patch: http://drupal.org/node/53008?

Was your patch tested? Could you include the final patched files?

Thanks, great work. However, in trying to review this I ran into some issues that aren't directly related to scheduler in itself but needs some work.

I have emailed datura regarding these to discuss it.

thanks and regards,
--AjK

I'm interested in helping with this, and I have some time to do it. Could you add your conversations/thoughts to the issue queue, so others can help?

Thanks in advance,
-Mark

The main problems I pointed out were

1. Patches should include all files and be referenced from drupal/
2. The main point is that the patch modifies DRUPAL-4-7 but totally changes the 4.7 release version

Basically, new features need to be generated against HEAD and not DRUPAL-4-7 which really ought to be a bug fix only branch.

If this additional functionality really is wanted in 4.7 then the patch must contain, as default, the original functionality. Think like this; imagine the patch was applied as is against 4.7, then all users who update their modules to pull in what they expect to be bug fixes suddenly find the module not only no longer works but they now need to install workflow and actions modules, learn it, apply it, etc, all while their site is broken. That's not acceptable.

So, if wanting this feature, make it against HEAD so it can be tried and tested. If it's really wanted for 4.7 then the patch must include original functionality (as default) and any new functionality as a "setting" that can be switched on.

I think that was the gist of the problem with the patch.

regards,
--AjK

I should also have said that the functionality is a major change and I would normally only do this against HEAD and release as appropiate. Major changes to released (4.7) I would prefer to avoid and only use the 4.7 branch for bug fixing.

I'm open to adding the odd feature but you can bet my reviewing of it will be somewhat harsh as I have to make sure that the current features / methods the module implements work as expected without surprises in store for end users.

Like I said, major new features really ought to be in HEAD.

For those that have been keeping up with dww's new module release system for Drupal 5 will know that incremental module releases will become available from Drupal 5 and beyond, which makes this type of feature addition alot easier. However, we are stuck with a legacy issue regarding DRUPAL-4-7. I'm not entirely sure if this incremental module release system wil be avaibale for 4.7 on d.o. when it comes online, we'll have to wait and see (or play with dww's test setup http://lists.drupal.org/archives/development/2006-10/msg00350.html which I haven't yet had the time to look at myself)

I've written a patch to provide scheduling via the workflow module:

http://drupal.org/node/90016

While I have nothing against having scheduler be workflow aware, and I like the idea of the patches, I decided the UI and logic would be a lot cleaner if incorporated into workflow itself.

Fixed in workflow module #90016: Scheduled workflow changes

Closing as outdated.