to enable/disable the menu item the checkbox isn't labeled - admin/structure/menu/manage/devel

CommentFileSizeAuthor
#7 menu_checkbox_labels_v4.patch1.23 KBmgifford
#4 menu_checkbox_labels_v3.patch1.23 KBmgifford
#2 screen-capture-12.png163.38 KBmgifford
#2 menu_checkbox_labels_v2.patch1.23 KBmgifford
menu_checkbox_labels_v1.patch827 bytesmgifford

Comments

Bojhan’s picture

Bojhan commented
Status: Needs review » Reviewed & tested by the community

Totally wierd we didn't add one in there. Applied here.

mgifford’s picture

mgifford
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new menu_checkbox_labels_v2.patch1.23 KB
new screen-capture-12.png163.38 KB

I overlooked something with this in patch one. The @row would still be displayed which is confusing. I've cleaned this up now. Sorry. I also standardized it with the weight in the same form.

It can be tested here: admin/structure/menu/manage/management

Sorry. I really should have seen that.

Everett Zufelt’s picture

Everett Zufelt commented
Status: Needs review » Needs work

Can we please get a reroll of this to be consistent with the approach in #882688: Label missing in block admin page?

Use @var instead of !var placeholder (menu item titles are user entered).

Perhaps change wording of title for enabled.

'Enable @title menu item'

Thanks

mgifford’s picture

mgifford
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new menu_checkbox_labels_v3.patch1.23 KB

Yup, that is better.

Everett Zufelt’s picture

Everett Zufelt commented
Status: Needs review » Reviewed & tested by the community

Looks good. Simple patch to add some labels to form controls.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Reviewed & tested by the community » Needs work 
+++ modules/menu/menu.admin.inc	18 Sep 2010 23:10:10 -0000
@@ -103,6 +103,8 @@ function _menu_overview_tree_form($tree)
+        '#title' => t('Enable @title menu item', array('@title' => $item['title'])),

"item" should be "link"

Powered by Dreditor.

mgifford’s picture

mgifford
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new menu_checkbox_labels_v4.patch1.23 KB

Thanks @sun! I've re-rolled with the enhancement.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Closed (duplicate)

Please merge this patch into #882694: Add missing form element titles for accessibility. Thanks.