Closed (fixed)
Project:
Workflow
Version:
7.x-1.x-dev
Component:
Views
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
16 Aug 2010 at 17:33 UTC
Updated:
5 Oct 2013 at 08:11 UTC
Jump to comment: Most recent file
Comments
Comment #1
gdud commentedThe problem is in implementation of hook_views_data() for workflow module. Field 'state' uses standard views_handler_field from views module. It renders value as it is in the database. I attached the patch that creates new very simple handler for state field (workflow_handler_field_state). This handler translates state name using t() function before render.
Works good for me.
Comment #2
adr_p commentedThanks, works perfectly.
Comment #3
christiaan_ commented+1 for patch #1 - Thank you very much
Comment #4
liquidcms commentedstill broken in D7
Comment #5
nancydruThanks. We don't use
// $Id$any more.Comment #6
nancydruComment #7
liquidcms commentedi changed this from minor to normal - likely should be major as it makes this module unusable for any multilingual site using views (which would seem like a big deal)
Comment #8
liquidcms commentedattached patch fixes this for D7 against latest -dev
Comment #9
perohu commentedThanks for the patch!
I've patched the stable release by hand, it's working great
Comment #10
johnvI'll commit this soon.
Comment #11
johnvI cannot get this working with latest -dev version. Can you create a new patch?
- patches need to be created from the (root) workflow direcotry, not from workflow_field directory.
- it contains trailing spaces.
- a line in workflow_field_info line is superflouos. I suppose you have patched against your own fork.
- "error: while searching for: 'title' => t('Current state name'), etc. "
Comment #12
liquidcms commentedsorry, yes, wasn't against latest -dev.. this version is. other comments:
first patch as well as this one:
- both are against correct workflow directory
- not sure about trailing spaces or CRs - i used tortoisesvn to create patch and tsvn correctly applied the patch as well as simply the patch command: patch --binary -p0 < [the patch file]
- i removed the superfluous line
- don't know what your last comment is about re: "error: while searching..." is this an issue with the patch itself or are you saying my changes do not work?
Comment #13
johnvThanks for the new patch. The last line was the actual error I stumbled upon. I could live with the other issues I mentioned.
Comment #14
johnvStill could not apply your patch, so added it manually here.
Please verify the latest -dev.