In views if you add a filter for the support ticket state views can't select the appropriate table in the database because the module doesn't check to see if the site has a table prefix.

I fixed mine by adding manually adding my prefix to line 11 of the file views_handler_filter_support_state.inc

CommentFileSizeAuthor
#3 support_views-fixing_sqls_without_curly_braces.patch1.8 KBrsevero
#1 support_views-prefixing_sql_table_names.patch1.74 KBrsevero

Comments

rsevero’s picture

rsevero commented
Status: Active » Needs review
StatusFileSize
new support_views-prefixing_sql_table_names.patch1.74 KB

Tables names aren't surrounded by {}. State, priority and client have the same problem.

The attached patch fixes this issue.

vietcoop’s picture

vietcoop commented
Status: Needs review » Needs work

That patch works fine, but please also use 2 spaces instead of tabs.

Also notice that _support_states() is available: 

/**
 * Helper function to list available states.
 */
function _support_states($all = TRUE, $sid = NULL) {}
rsevero’s picture

rsevero commented
Status: Needs work » Needs review
StatusFileSize
new support_views-fixing_sqls_without_curly_braces.patch1.8 KB

This last attached patch uses 2 sapces in the lines that I changed. AFAICT the whole code for this modules uses tabs instead of spaces.

Changed the get_value_options() method to call _support_states() instead of running it's own SQL call.

MisterSpeed’s picture

MisterSpeed commented
Status: Needs review » Fixed

Works + committed; thanks everyone !

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.