I needed to use this module in conjunction with module_grants and I found I needed to make the following modification to the _talk_access() function in talk.module to allow the Talk tab to be visible on unpublished nodes.


/**
 * Helper item for talk_menu: access callback.
 */
function _talk_access($node) {
  if (module_exists('module_grants'))    return ($node->nid && _talk_node_comment_value($node) && talk_activated($node->type) && user_access('access comments') && module_grants_node_access('view', $node) && (variable_get('talk_page_no_comments', TRUE) || $node->comment_count));
  else
    return ($node->nid && _talk_node_comment_value($node) && talk_activated($node->type) && user_access('access comments') && node_access('view', $node) && (variable_get('talk_page_no_comments', TRUE) || $node->comment_count));
}

Don't know if this sort of thing would be able to be included in future versions of Talk.

CommentFileSizeAuthor
#3 talk-885156.patch1007 bytesjzornig
#1 talk-885156.patch1 KBjzornig

Comments

jzornig’s picture

Version: 6.x-1.6 » 6.x-1.7
Status: Active » Needs review
StatusFileSize
new1 KB

I've rolled a patch for this agains the 1.7 release. I hope it could make it into the 1.8 release.

Status: Needs review » Needs work

The last submitted patch, talk-885156.patch, failed testing.

jzornig’s picture

Status: Needs work » Needs review
StatusFileSize
new1007 bytes

Updated patch.

Status: Needs review » Needs work

The last submitted patch, talk-885156.patch, failed testing.

jarodms’s picture

Issue summary: View changes
Status: Needs work » Closed (outdated)