So, with this page here admin/config/system/actions

A label is missing that can be easily added

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mgifford’s picture

Status: Active » Needs review

forgot to bump the bot. Again, there are no visual changes here.

mgifford’s picture

FileSize
34.68 KB

I made the element-invisible red in Firebug & got this screenshot for those who want it.

The text could be more descriptive. Suggestions are appreciated.

Bojhan’s picture

Status: Needs review » Reviewed & tested by the community

Create seems good? I mean the screen reader already tells you to choose right?

mgifford’s picture

The screen reader already tells the user that it's a select box and they have a choice yes.

Thanks Bojhan!

mgifford’s picture

system_admin_label_v1.patch queued for re-testing.

sun’s picture

I wonder why we have that surrounding fieldset in the first place? What is that good for?

sun’s picture

system_admin_label_v1.patch queued for re-testing.

mgifford’s picture

I do think that the fieldset places the select item apart more. I suspect it's good for usability. I think it sets it apart from the list of 'Available actions' above it.

We could nix this to remove the fieldset:

  $form['parent'] = array(
    '#type' => 'fieldset',
    '#title' => t('Create an advanced action'),
    '#attributes' => array('class' => array('container-inline')),
  );

But I think that should be considered apart from this issue with the label & with a review for UX patterns.

Good question though. I'd really like to see a pattern guide get started for D8 UX. What are the patterns that we want to see repeated & used throughout core & contrib modules. How do we define & replicate best practices in the user interface?

Status: Reviewed & tested by the community » Needs work

The last submitted patch, system_admin_label_v1.patch, failed testing.

sun’s picture

Status: Needs work » Closed (duplicate)