Closed (duplicate)
Project:
Drupal core
Version:
7.x-dev
Component:
system.module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
17 Aug 2010 at 18:07 UTC
Updated:
29 Sep 2010 at 17:29 UTC
Jump to comment: Most recent file
Comments
Comment #1
mgiffordforgot to bump the bot. Again, there are no visual changes here.
Comment #2
mgiffordI made the element-invisible red in Firebug & got this screenshot for those who want it.
The text could be more descriptive. Suggestions are appreciated.
Comment #3
Bojhan commentedCreate seems good? I mean the screen reader already tells you to choose right?
Comment #4
mgiffordThe screen reader already tells the user that it's a select box and they have a choice yes.
Thanks Bojhan!
Comment #5
mgiffordsystem_admin_label_v1.patch queued for re-testing.
Comment #6
sunI wonder why we have that surrounding fieldset in the first place? What is that good for?
Comment #7
sunsystem_admin_label_v1.patch queued for re-testing.
Comment #8
mgiffordI do think that the fieldset places the select item apart more. I suspect it's good for usability. I think it sets it apart from the list of 'Available actions' above it.
We could nix this to remove the fieldset:
But I think that should be considered apart from this issue with the label & with a review for UX patterns.
Good question though. I'd really like to see a pattern guide get started for D8 UX. What are the patterns that we want to see repeated & used throughout core & contrib modules. How do we define & replicate best practices in the user interface?
Comment #10
sunPlease merge this patch into #882694: Add missing form element titles for accessibility. Thanks.