There is an extraneous/erroneous chunk of step removal code still in media_mover_configuration::remove(), attached patch removes it and makes a slight update to the delete message to include configuration name/description.
| Comment | File | Size | Author |
|---|---|---|---|
| config_delete_fix.patch | 1.85 KB | civicpixel |
Comments
Comment #1
arthurf commentedThe fix to the ui module is clearly need, so I've committed that. The remove of the step deletion however I'm a bit concerned about. The problem with removing that code is that the steps need to be pulled out of the step map table to prevent cruft build up- perhaps something like:
The problem still is that as these steps are removed from the step map, they also need to be checked for uniqueness- if no other configuration is using them they should probably be deleted... not quite sure on that one.
Comment #2
civicpixel commentedTested on our development and live servers for a week, marking as fixed.