Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
file.module
Priority:
Major
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
17 Aug 2010 at 19:14 UTC
Updated:
29 Jul 2014 at 18:59 UTC
Jump to comment: Most recent
Comments
Comment #2
Everett Zufelt commentedI haven't looked, but @davereid told me on IRC that we should be looking in file.module
Comment #3
Everett Zufelt commentedEverettZ
Curious if anyone knows where the image upload form in d7 is generated? can't seem to find it in image.module
davereid
it's in file.module
EverettZ
davereid: thanks.
marcingy
isn't it in image.field.inc
davereid
yes, but it re-uses file_field_widget_form
davereid
image_field_widget_form?
Druplicon
image_field_widget_form: Implements hook_field_widget_form(). => image_field_widget_form(&$form, &$form_state, $field, $instance, $langcode, $items, $delta,
$element) =>
http://api.drupal.org/api/function/image_field_widget_form/7
marcingy
yes very true it is wrapper to the file field widget
Comment #4
mgiffordI've tried adding in a title element even in a rough form in
file_field_widget_form() in modules/file/file.field.inc
or
image_field_widget_form() in modules/image/image.field.inc
Using witty little pieces of PHP like:
To see if I can get it to appear in the right place. And I almost can. However, I'm hitting the wrong form ID. It should be "edit-field-image-und-0-upload" but It is just listed as "edit-field-image-und-0".
Any other thoughts on how to nudge this ahead?
Comment #5
sunPlease merge this patch into #882694: Add missing form element titles for accessibility. Thanks.
Comment #6
mgiffordThere is no patch to move here.
It might make sense when there is something to bring into core to meld into a master patch, but there isn't something here in this instance to merge.
The expertise for the file.module are here and it needs to sit with this component until there is a solution.
Stuffing it into a master patch will just ensure that it will get lost.
Comment #7
Everett Zufelt commentedSetting to priority Major. Missing labels are a WCAG 2.0 level A success criteria. This IMO is major (if not critical).
Comment #8
bowersox commented+1 for this being important to fix
Comment #9
catchMoving to a task, not clear if this was ever fixed in the other patch or not.
Comment #10
Everett Zufelt commented@mgifford
It appears that this issue is fixed in D7-dev. Can you please confirm, and perhaps confirm in D8 head as well?
Comment #11
chx commentedComment #12
mgiffordThanks chx.