I know this can be handled by overriding the theme functions but I thought it might be useful to a lot of people.

It would be useful to add the menu name as a class of the nice menus ul tag.
This would make nice menus more compatible with a great deal of themes, including garland, that use primary-links & secondary-links as classes for those menus.

The patch is for the current dev.

CommentFileSizeAuthor
#3 886338.3-menu-class.patch1.05 KBdeviantintegral
nice_menus-menu_name_class.patch783 bytesagileware

Comments

add1sun’s picture

add1sun commented
Version: 6.x-2.x-dev » 7.x-2.x-dev
zevans23’s picture

zevans23 commented

Fantastic. I came here looking for support for theme colours and hoping I could make it land in the right place without diving into the CSS. This is a good first step - patch works and has put the menu on the right of the title banner, where it belongs in Garland, great. Now just need to swap colours around. It tried it in 6.x by the way and it works.

deviantintegral’s picture

deviantintegral commented
StatusFileSize
new 886338.3-menu-class.patch1.05 KB

A reroll of this for 7.x-2.x. If this is good, the original patch against 6.x should be fine to commit as well.

xiukun.zhou’s picture

xiukun.zhou commented

Hi, deviantintegral
This may be conflict with other menu so I do not think this is a good patch

Please let me know if you would have any other questions, comments, issues or concerns on any of these changes, I would be glad to provide more information.
Thanks again to everyne for the help and great work on this issue.

Cheers!

xiukun.zhou’s picture

xiukun.zhou commented
Status: Needs review » Active
davidtrainer’s picture

davidtrainer commented
Status: Active » Needs work

@xiukun.zhou

To alleviate potential class name collisions, how about if we prefix the menu name with "nice-menu-" and use that as a class, just like the way $direction is handled?

xiukun.zhou’s picture

xiukun.zhou commented

Thanks davidtrainer.
this idea is very good.

xiukun.zhou’s picture

xiukun.zhou commented
Version: 7.x-2.x-dev » 7.x-2.1
Status: Needs work » Fixed

Thanks a lot to davidtrainer, Agileware and everyone else for the great work on the patches, testing, reviews and reporting.

It's more time this got committed and I went ahead and had this rolled at:
7.x-2.x: 2272f73.

6.x-2.x: 65a223f.

Marking this as fixed.

Please let me know if you would have any other questions, comments, issues or concerns on any of these changes, I would be glad to provide more information.
Thanks again to everyne for the help and great work on this issue.

Cheers!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.