Hi guys,

This is in link with the E_ALL issues presented in link with the CA module.

#498990: E_ALL Compliance for the CA Module

The next CA patch will not include this very entry which is a bug in the logic.

See point #17 of #498990: E_ALL Compliance for the CA Module for more info.

Patch for that very bug is attached here.

Thank you.
Alexis Wilke

CommentFileSizeAuthor
ubercart-2.x-ca_predicate_pid-6.x.patch522 bytesAlexisWilke

Comments

tr’s picture

tr commented
Assigned: AlexisWilke » Unassigned

Bumping. My uncertainty here is that if this code is so wrong, why hasn't it caused problems?

AlexisWilke’s picture

AlexisWilke commented

The reason why I put this one here is because fixing the E_NOTICE means changing the behavior. Without this fix, what appears within the if() condition is simply never executed. Whether it is important for relatively good functioning, I do not know.

Thank you.
Alexis

Status: Needs review » Needs work

The last submitted patch, ubercart-2.x-ca_predicate_pid-6.x.patch, failed testing.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Fixed

Fixed in http://drupalcode.org/project/ubercart.git/commit/c0d061f

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.