CVS edit link for ossolutionsorg

To contribute code back to the community that has provided so much already.
CommentFileSizeAuthor
#9 wolframAlpha_v2.zip5.07 KBrootedlogics
#1 wolframAlpha.zip2.58 KBrootedlogics

Comments

rootedlogics’s picture

rootedlogics commented
Title: ossolutionsorg [ossolutionsorg] » WolframAlpha Module
StatusFileSize
new wolframAlpha.zip2.58 KB

Here is the initial module that I would like to commit. It allows site administrators to add and manage Wolfram|Alpha search boxes on their site. They may choose among the small, medium, and large search boxes provided by Wolfram|Alpha which creates blocks that the site maintainers may place on their site.

rootedlogics’s picture

rootedlogics commented
Status: Postponed (maintainer needs more info) » Needs review
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: WolframAlpha Module » ossolutionsorg [ossolutionsorg]
Status: Needs review » Needs work

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review the code, pointing out what it needs to be changed.

As per requirements, the motivation message should be expanded to contain more features of the proposed project. For themes, it should include also a screenshot of the theme, and (when possible) a link to a working demo site using the proposed theme; for modules, it should include also a comparison with the existing solutions.

rootedlogics’s picture

rootedlogics commented
Status: Needs work » Needs review

Good Morning,

I don't immediately see where I can update my motivation message so until I discover the location (I found it when I went back in history for signing up for the account but not post-creation) I will post the revised version here:

I wish to contribute code back to the community that has provided so much already. I am initially providing a Wolfram|Alpha module that will allow users to select up to three different sized Wolfram|Alpha search boxes (small, medium, large) which creates blocks with the necessary code that administrators may use to place anywhere on their site -- using the most optimal size for their particular application.

I'm also working on a module that fetches and caches external content that the administrator desires with a TTL for each individual item that is then placed in a block for use anywhere on the site.

Additionally, I am open to helping maintain existing modules wherever the need may be or even picking up orphaned modules.

rootedlogics’s picture

rootedlogics commented

Requesting update on status or where I need to improve the code. Thanks for your time.

roger.soper’s picture

roger.soper commented
Category: task » support
Priority: Normal » Major

I would really like to see this module, I have a few education based sites that could use it once its available to the public.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Category: support » task
Priority: Major » Normal
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work
Issue tags: +Module review
  • The points reported in this review are not in order or importance / relevance.
  • Most of the times I report the code that present an issue. In such cases, the same error can be present in other parts of the code; the fact I don't report the same issue more than once doesn't mean the same issue is not present in different places.
  • Not all the reported points are application blockers; some of the points I report are simple suggestions to who applies for a CVS account. For a list of what is considered a blocker for the application approval, see CVS applications review, what to expect. Keep in mind the list is still under construction, and can be changed to adapt it to what has been found out during code review, or to make the list clearer to who applies for a CVS account.
  1. The module doesn't have a .info file, nor an .install file.
  2. See http://drupal.org/coding-standards to understand how a module should be written. In particular, see how Drupal variables, global variables, constants, and functions defined from the module should be named.
  3. Hook implementation comments should be like the following one: 
    /**
 * Implements hook_menu().
 */
  4. Drupal 6 doesn't use a hook hook_admin(); the function is simply a form builder.
  5. Two modules cannot define the same permission.
rootedlogics’s picture

rootedlogics commented
Status: Needs work » Needs review
StatusFileSize
new wolframAlpha_v2.zip5.07 KB

Thank you for the review. I have made the changes that were asked for.

1. Added the .info file to the zip file (forgot to included it with the original zip file).
2. Made sure spacing and comments were to standard.
3. Updated for the hook declarations
4. Removed the unneeded hook_perm function

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno
Status: Needs review » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)
Issue tags: -Module review

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Module review

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Component: Miscellaneous » new project application
Issue summary: View changes
Status: Closed (fixed) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.