Incomplete verification of assertions

+ * The next series of updates should start at 8000.
+ */
\ No newline at end of file

could the committer add a newline after these lines.

While we are no in beta yet, openid_update_7000() should just be openid_update_6000(), and we can remove the db_table_exists() call.

BTW this is a followup to SA-CORE-2010-002.

Looks like nobody is working on this yet on the summit, I'll do a re-roll, doesn't look too complicated...

Just a simple re-roll with the update function renamed and newlines added...

+/**
+ * @defgroup openid-updates-6.x-to-7.x OpenID updates from 6.x to 7.x
+ * @{
+ */

^ Those should be in the Drupal 6 extra group.

Obviously...

The test fail looks totally unrelated and works for me locally. Maybe the test is unstable....

I looked at this patch and it looks RTBC, assuming that the testbot gives us the green light.

+++ modules/openid/openid.install
@@ -84,3 +110,46 @@ function openid_requirements($phase) {
+        'description' => 'The value of openid.response_nonce'

Very minor but we're missing a point in the description. I can fix that prior to committing.

#7: openid-incomplete-verification-assertions-D7-3.patch queued for re-testing.

Hmm, the last 2 patches have failed for two different reasons within 2 hours. I haven't followed what has gone in today and/or if anything broke the test bot, but I requested a re-test and am crossing my fingers that this passes.

This may be "critical," but it's not a beta-blocker. People barely notice when OpenID is broken in stable releases.

$0.02: If I understood correctly, if this doesn't land before beta, we will have to change the update functions...

This was rtbc before the bot glitch.
BTW Dries look at #8 before commiting ;)

Great. Committed to CVS HEAD. Thanks.