There are several things here:

1) When adding an item to the invoice, it seems that the weight is always 0, there it doesn't display in the order added.
2) You cannot use the screens to change the order (i.e. the weight field) for invoice items (but you can for tasks.
3) Even if you manually update the weight in the database (as I do for a customer workaround) the order of the items on the HTML and PDF printouts are not using the weight.

Proposed changes:
1) when a new invoice item is created, it will automatically add 1 to the max weight already in the invoice item table.

2a) Add weight field on the screens for each item (already exists in the database) so that users can edit. This would be a free number not a controlled list as with tasks as the numbers could be high. i.e. My customer has nearly 100 items on some invoices.
AND/OR
2b) create a similar tab as the tasks (under a project node) so that a user can drag/drop items to re-order. This might require more research on my part.

3) Change the sql to order by weight.

I can start this once I get my current issue (#567558: Extend auto-billing to other types of Storm node) committed in the next few days (I hope).

CommentFileSizeAuthor
#12 887638.patch2.24 KBtchurch
#8 887638.patch1.86 KBtchurch
#8 887638.jpg117.54 KBtchurch
#6 887638.jpg102.74 KBtchurch

Comments

juliangb’s picture

juliangb commented

See also: #771244: Item ordering in Print HTML .

tchurch’s picture

tchurch commented

I have closed #771244: Item ordering in Print HTML as duplicate and will fix the issue along with the other fixes mentioned here.

tchurch’s picture

tchurch commented

Note - fix for point 3 (as from #771244: Item ordering in Print HTML ):

In storminvoice.module, the ordering should be added in the function storminvoice_getitems(), like this:

function storminvoice_getitems($invoice_vid) {
$s = "SELECT sit.* FROM {storminvoice_items} AS sit WHERE sit.invoice_vid = %d ORDER BY sit.weight ASC";
$r = db_query($s, $invoice_vid);

$items = array();
while ($i = db_fetch_object($r)) {
$items[] = $i;
}
return $items;
}

tchurch’s picture

tchurch commented

I'd like to work on this for 1.35.

I have a customer who would like this and I have to keep running manual database updates for it.

Any thoughts?

juliangb’s picture

juliangb commented

Nothing to add to your proposed changes.

tchurch’s picture

tchurch commented
StatusFileSize
new 887638.jpg102.74 KB

I've attached a screen shot of the invoice edit page. It shows a new field for weight. Users can put a number in there.
The smaller the number, the higher on the list (like all other Drupal weight fields).

This field already existed in the DB. I've added it to the edit page.

I'll work on the other bits (and the patch) later.

Any comments?

juliangb’s picture

juliangb commented

How about moving the weight field to the right of the amount field? This might be a bit easier for those who don't want to change the weight.

As an aside, a nice to have might be to have click-draggable fieldsets. Unless you're particularly keen on working on this though, I'd suggest we make the bug fix as you have been doing and open a new feature request for that.

tchurch’s picture

tchurch commented
Status: Active » Needs review
StatusFileSize
new 887638.jpg117.54 KB
new 887638.patch1.86 KB

Patch and new image.

juliangb’s picture

juliangb commented 
+++ storminvoice/storminvoice.module	12 Oct 2010 18:03:25 -0000
@@ -501,6 +497,14 @@ function storminvoice_form(&$node) {
+      '#type' => 'textfield',

We should use the 'weight' #type.

+++ storminvoice/storminvoice.module	12 Oct 2010 18:03:25 -0000
@@ -501,6 +497,14 @@ function storminvoice_form(&$node) {
+      '#withnull' => 'true',

What does this bit do?

Powered by Dreditor.

tchurch’s picture

tchurch commented

I also forgot to add the fix from #3. Now done.

#withnull - no idea. I copied the code from another field. Now removed.

I'm not too happy with type 'weight'. It makes it a dropdown box, limiting the list to -10 to 10.

I have customers who add (sometimes) approx. 100 items to an invoice and the only real way to get them in the correct order is to have a freetext field.

Currently, I'm running a manual database update against storminvoice_items to order them so numbers can go up to 100 or more.

type 'weight' seems too restrictive to me.

I can set it if that's the general opinion.

juliangb’s picture

juliangb commented

Ok, agreed.

tchurch’s picture

tchurch commented
StatusFileSize
new 887638.patch2.24 KB
juliangb’s picture

juliangb commented
Status: Needs review » Reviewed & tested by the community

Ok, seems good.

tchurch’s picture

tchurch commented
Status: Reviewed & tested by the community » Fixed

committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.