There're two theming issues with this module related to css. I've found workarounds for both but it would be great to find a real solution.
First of all your css file changes the style of global .form-item so every form element now is placed inline with others. I've noticed that because of my poll block visible on /analytics page. I'm not css guru but I think you should use
#edit-period-wrapper {
display: inline;
padding-right: 5px;
}instead of
.form-item { display: inline; padding-right: 5px; }
Anyway it works for me :)
The second one is related to css too. There's an attribute "float=left" activated for every div with "quant-chart" class and it forces my content-bottom region to take place on the right hand side of the top chart generated by Quant. I've added "magic" empty div with "clear=both" before "return $content;" string in theme_quant_page theming function and it did its usual trick but IMO that was an ugly solution.
I think it can be useful for other people who want to implement analytics feature on their websites to try my workaround and that's why I attached two files - one for quant.css and another for quant.module. And sure if you think that's the best possible solution feel free to patch your module with them too :) Thank you for Quant!
| Comment | File | Size | Author |
|---|---|---|---|
| quant_float.patch | 349 bytes | Ingumsky | |
| quant_form_inline.patch | 295 bytes | Ingumsky |
Comments
Comment #1
mstef commentedGood points - I will review the patches and improve the CSS. I barely spent more than 15 seconds doing the CSS. It was a quick addition just to make it look nice and I wasn't considering having the charts on pages with other content. Good catch!
And you're very welcome. I have high hopes for this module.
Comment #2
Ingumsky commentedGreat. Thank you :)
Comment #3
mstef commentedCommited